Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable stricter linting #872

Merged
merged 13 commits into from
Mar 4, 2024
Merged

Enable stricter linting #872

merged 13 commits into from
Mar 4, 2024

Conversation

hoechenberger
Copy link
Member

Before merging …

  • Changelog has been updated (docs/source/changes.md)


from annotated_types import Ge, Interval, Len
from mne import Covariance
from mne_bids import BIDSPath

from mne_bids_pipeline.typing import (
from mne_bids_pipeline._types import (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speaking of public vs private, this one was meant to be public like numpy.typing because people might want to annotate with some of our types like ArbitraryContrast

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like from mne_bids_pipeline.typing import ArbitraryContrast or similar

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will revisit this tomrrow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larsoner I have reverted this change

@hoechenberger hoechenberger changed the title Enable stricter linting and avoid naming conflict with build-in typing module Enable stricter linting Mar 4, 2024
@hoechenberger hoechenberger marked this pull request as ready for review March 4, 2024 12:06
@larsoner larsoner merged commit 022c59b into mne-tools:main Mar 4, 2024
52 checks passed
@larsoner
Copy link
Member

larsoner commented Mar 4, 2024

Thanks @hoechenberger !

@hoechenberger hoechenberger deleted the ruff branch March 4, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants