MAINT: DRY kwarg passing #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
commented
Jun 26, 2023
| eeg_template_montage=config.eeg_template_montage, | ||
| fix_stim_artifact=config.fix_stim_artifact, | ||
| stim_artifact_tmin=config.stim_artifact_tmin, | ||
| stim_artifact_tmax=config.stim_artifact_tmax, | ||
| find_flat_channels_meg=config.find_flat_channels_meg, | ||
| find_noisy_channels_meg=config.find_noisy_channels_meg, |
There was a problem hiding this comment.
For this function for example now it's trivial to see that the only params it actually needs (other than raw data loading params) are the find_*_channels_meg values (EDIT: plus extra_kwargs above)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging …
docs/source/changes.md)I went to work on #574 and the sheer volume of
kwargsinget_configthat must be used toimport_*_datamade it really hard to start from one of thesteps/preprocessing/*.pyfiles to add a new step. This PR is a no-op from the user standpoint but refactors to:_bids_kwargsfunction that returns some standard BIDS kwargs likecfg.space. Eventually we should use this everywhere probably but I'm just starting withsteps/preprocessingfor now._import_data_kwargsfunction that gets theconfigparams needed for reading raw dataShould be a lot more red than green here. I don't expect the first version to pass -- locally I've only run
ds004229-- but hopefully it won't require many more iterations to get right!