Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various doc improvements #693

Merged
merged 24 commits into from
Dec 18, 2022
Merged

Various doc improvements #693

merged 24 commits into from
Dec 18, 2022

Conversation

hoechenberger
Copy link
Member

Before merging …

  • Changelog has been updated (docs/source/changes.md)

@larsoner
Copy link
Member

Looks good from a source perspective, feel free to merge when green and the rendering looks good @hoechenberger ! FYI for PRs like this you can commit with [circle ds003775] or similar to save a lot of CI cycles and get faster turnaround

@hoechenberger hoechenberger force-pushed the doc-improvements branch 2 times, most recently from 048eeb3 to f3bf86f Compare December 15, 2022 23:11
@larsoner larsoner added this to the 1.1 milestone Dec 16, 2022
@larsoner
Copy link
Member

Tests now pass (fixed indentation and line key). Current rendering: https://output.circle-artifacts.com/output/job/ca821a62-a99f-473c-be4b-422fe2a731a9/artifacts/0/site/index.html

@hoechenberger
Copy link
Member Author

Thanks Eric!

@larsoner
Copy link
Member

@hoechenberger still WIP or good to merge?

@hoechenberger
Copy link
Member Author

@larsoner Still WIP!!

@hoechenberger hoechenberger marked this pull request as ready for review December 18, 2022 21:15
@hoechenberger hoechenberger changed the title Various doc improvements (WIP) Various doc improvements Dec 18, 2022
@hoechenberger
Copy link
Member Author

@larsoner I'm still not 100% happy but I think this can be merged and we can iterate at some later time

@hoechenberger
Copy link
Member Author

Rendered docs:
https://output.circle-artifacts.com/output/job/7cb7704c-6141-4de5-af57-9c10c3dd8a1d/artifacts/0/site/index.html

@hoechenberger hoechenberger merged commit 8dd9237 into mne-tools:main Dec 18, 2022
@hoechenberger hoechenberger deleted the doc-improvements branch December 18, 2022 21:53
@larsoner
Copy link
Member

Time for hopefully last release before inclusion with MNE 1.3 installers?

@hoechenberger
Copy link
Member Author

Yep sounds good to me!

@hoechenberger hoechenberger mentioned this pull request Dec 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@hoechenberger @larsoner