Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixed formatting and doc improvements #33

Merged
merged 1 commit into from
Jun 21, 2019
Merged

mixed formatting and doc improvements #33

merged 1 commit into from
Jun 21, 2019

Conversation

sappelhoff
Copy link
Member

minor changes while I was going through the codebase.

Points I noticed:

  • It is unclear how to get the MRI data for the "example" described in the README
  • The "example" data on OSF contains an empty system calibration files directory in LocalizerDATA ... is this an error?

@jasmainak
Copy link
Member

MRI documentation is kind of sparse in MNE as well :-)

maybe you can adapt this somehow:

https://github.com/mne-tools/mne-biomag-group-demo/blob/master/scripts/processing/01-anatomy.py ?

@agramfort
Copy link
Member

no objection to merge but FYI the readme file is not really up to date as we use here sample. The readme comes from this fork. https://github.com/brainthemind/CogBrainDyn_MEG_Pipeline

@sappelhoff
Copy link
Member Author

Okay, but is this master? Or has that fork now become master?

Where should I primarily work so that I don't cause conflicts?

Feel free to merge

@agramfort
Copy link
Member

agramfort commented Jun 7, 2019 via email

@sappelhoff
Copy link
Member Author

cc @jasmainak

this one can be merged I believe

@jasmainak jasmainak merged commit 7f071ae into mne-tools:master Jun 21, 2019
@jasmainak
Copy link
Member

Merged, moving on to more serious contributions ;)

@sappelhoff sappelhoff deleted the minorclean branch June 21, 2019 14:11
@sappelhoff
Copy link
Member Author

yes! perhaps you could review https://github.com/bids-standard/bids-validator/pull/789? it's blocking mne-tools/mne-bids#209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants