Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Angular 18 and above #96

Closed
Akxe opened this issue May 24, 2024 · 2 comments · Fixed by #97
Closed

Upgrade to Angular 18 and above #96

Akxe opened this issue May 24, 2024 · 2 comments · Fixed by #97

Comments

@Akxe
Copy link

Akxe commented May 24, 2024

Hi, In order not to block upgrades to newer versions of Angular, you could move your Angular dependencies to devEependencies, and thus allowing users to install any version they want :)

See https://github.com/VadimDez/ng2-pdf-viewer/blob/master/package.json for insiration.

@mnahkies
Copy link
Owner

This is actually already the case for the package itself - it specifies the angular dependencies as peerDependencies with version constraints based on what versions are officially supported https://github.com/mnahkies/ng-qrcode/blob/master/projects%2Fng-qrcode%2Fpackage.json#L17-L24

Most package managers will log a warning but not prevent you from going outside these constraints in my experience, though it's possible that some are stricter.

I'll be aiming to upgrade/test/release this weekend regardless.

mnahkies added a commit that referenced this issue May 25, 2024
- updates to support angular v18
- refreshes dependencies and updates to `yarn@^4`
- auto-publish demo site

closes #96
@mnahkies
Copy link
Owner

Update to v18 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants