Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intermediate types for parsing #50

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Add intermediate types for parsing #50

merged 4 commits into from
Oct 25, 2023

Conversation

mmynk
Copy link
Owner

@mmynk mmynk commented Oct 25, 2023

Add intermediate types.
Netlink struct read from library is converted to these intermediate types which is then converted to the final types.
This allows upgrading or changing underlying netlink libraries easier (could also allow for IoC).

Resolves #46

Define intermediate `tc` and `link` message types
Convert structs from netlink to these new intermediate types
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #50 (c4aacc7) into main (0afad9c) will increase coverage by 1.84%.
The diff coverage is 94.49%.

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   89.90%   91.74%   +1.84%     
==========================================
  Files          10       11       +1     
  Lines        1000     1514     +514     
==========================================
+ Hits          899     1389     +490     
- Misses        101      125      +24     
Files Coverage Δ
src/errors.rs 0.00% <ø> (ø)
src/lib.rs 46.87% <ø> (ø)
src/link.rs 100.00% <100.00%> (+12.50%) ⬆️
src/test_data.rs 100.00% <100.00%> (ø)
src/tests.rs 100.00% <100.00%> (ø)
src/qdiscs/fq_codel.rs 78.33% <88.88%> (-1.33%) ⬇️
src/tc.rs 90.67% <94.28%> (-2.58%) ⬇️
src/types.rs 43.47% <36.36%> (-3.19%) ⬇️
src/class/htb.rs 68.51% <66.66%> (+7.40%) ⬆️
src/netlink.rs 91.13% <91.16%> (+1.62%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mmynk mmynk merged commit 376ca68 into main Oct 25, 2023
6 checks passed
@mmynk mmynk deleted the enhancement/deps branch October 25, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce coupling with downstream dependencies
1 participant