Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

includes: Enhance Twitter share link #538

Merged
merged 1 commit into from
Sep 19, 2016

Conversation

kylemanna
Copy link
Contributor

  • Include the page title before the URL
  • If twitter.username is set, pass the via paramter for attribution

* Include the page title before the URL
* If twitter.username is set, pass the `via` paramter for attribution
Copy link
Owner

@mmistakes mmistakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the PR!

@mmistakes mmistakes merged commit d4ee7ff into mmistakes:develop Sep 19, 2016
mmistakes pushed a commit that referenced this pull request Sep 19, 2016
* Include the page title before the URL
* If twitter.username is set, pass the `via` paramter for attribution
@kylemanna kylemanna deleted the twitter-share-enhancement branch September 19, 2016 16:41
TheCodedSelf pushed a commit to TheCodedSelf/thecodedself.github.io that referenced this pull request Dec 7, 2016
* Include the page title before the URL
* If twitter.username is set, pass the `via` paramter for attribution
jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this pull request May 6, 2017
* Include the page title before the URL
* If twitter.username is set, pass the `via` paramter for attribution
makaroniame added a commit to makaroniame/makaroniame-old.github.io that referenced this pull request May 18, 2022
* Include the page title before the URL
* If twitter.username is set, pass the `via` paramter for attribution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants