Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show date of posts #2526

Merged
merged 12 commits into from
Aug 4, 2020
Merged

Show date of posts #2526

merged 12 commits into from
Aug 4, 2020

Conversation

limjh16
Copy link
Contributor

@limjh16 limjh16 commented May 9, 2020

This is an enhancement or feature.

Summary

Adds an optional "date" alongside the read time in _includes/read_time.html

As a result of this change, I renamed read_time.html to post__meta.html

Context

To enable the date, it is similar to enabling the read time, just set show_date to true in _config.yml

Date only screenshots

Screenshot 2020-05-09 at 10 22 58 PM
Screenshot 2020-05-09 at 10 22 56 PM
Screenshot 2020-05-09 at 10 22 53 PM

Date+read time screenshots

Screenshot 2020-05-09 at 10 23 25 PM
Screenshot 2020-05-09 at 10 23 23 PM
Screenshot 2020-05-09 at 10 23 27 PM
Screen Shot 2020-05-09 at 22 23 45

@iBug
Copy link
Collaborator

iBug commented May 9, 2020

Looks exceptionally awesome! I like it. Not sure what @mmistakes thinks though, as he's been resistant to adding extra configurations (ref).

@iBug
Copy link
Collaborator

iBug commented May 9, 2020

For the file name, I suggest post__meta.html as it's clearer than "rtsd", which is pretty obscure per se.

@limjh16
Copy link
Contributor Author

limjh16 commented May 10, 2020

Looks exceptionally awesome! I like it. Not sure what @mmistakes thinks though, as he's been resistant to adding extra configurations (ref).

Woops, should have done a check to see whether others have suggested this before... sorry about that
Also, thanks for linking that issue, I realised I missed out editing _includes/page__hero.html from there...

Copy link
Collaborator

@iBug iBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like there's no need to differentiate between page and post - posts are a subclass of pages so using page.whatever everywhere would just suffice. This can simplify a lot of the logics around and also eliminate the need to pass an extra p variable to {% include %}.

@limjh16
Copy link
Contributor Author

limjh16 commented May 15, 2020

Hey, I had tested that before but in _includes/archive-single.html page.whatever doesn't work. Whenever the archive-single include is called, it's usually in a for-loop where something is assigned to the post variable, that's probably why the page variables doesn't work in that case

@iBug
Copy link
Collaborator

iBug commented May 15, 2020

I would probably do something else like {% assign page = post %} before including the new file in the case you described. Or maybe {% assign page = page | default: post %} at the top of the new file. Or maybe {% assign post_date = page.date | default: post.date %} or something similar. Differentiating between variables makes the code less maintainable.

@mmistakes
Copy link
Owner

mmistakes commented May 15, 2020

The complexity comes from site.pages, they don't have dates generally. This is the big difference between posts and pages/collections. Can't assume the user will add a date to the YAML front matter either which can really start to complicate your Liquid spaghetti code.

If I were to consider adding dates inline with read time I'd do it like my other themes e.g. So Simple or Basically Basic.

@iBug
Copy link
Collaborator

iBug commented May 15, 2020

@mmistakes It could be documented. Jekyll supports parsing date from the yyyy-mm-dd-post-title.md filename format even for documents other than those in the _posts collection (e.g. custom collection). If the entire ecosystem around this theme's setup is properly documented, I'd say I see no problem implementing this - it's a vital piece of information for a post as iterated multiple times by multiple users in #1428.

Anyways, whatever feature that a lot of people find useful, I‘m probably for it.

@mmistakes
Copy link
Owner

@iBug That's fine. To your point about reducing complexity. I'd suggest looking how I did it in my other themes, it's very similar to your suggestions. Basically normalize the variable names with assigns, then they can be piped through 1 include.

Simplifies the logic so you can do: If site dates are enabled and the document has a date set then show date. If read time is enable show that. Instead of if post... do this... if page do that like the original PR had.

@limjh16
Copy link
Contributor Author

limjh16 commented May 16, 2020

doing {% assign page = post | default page %} seems to work, thanks for the suggestion @iBug!

_includes/post__meta.html Show resolved Hide resolved
@iBug
Copy link
Collaborator

iBug commented May 17, 2020

I think it's better to put post date before read time for being more intuitive.

_includes/archive-single.html Outdated Show resolved Hide resolved
@iBug
Copy link
Collaborator

iBug commented May 17, 2020

@mmistakes Any ideas? This PR is at a perfect state now, even better than I could imagine. As discussed multiple times before, many users of the theme are in serious need of post dates on their websites. It's not hard to imagine that more users will happily enable it if it's easily available. I understand your view on "fewer configurations", but something so important like post date is definitely worth it.

@iBug
Copy link
Collaborator

iBug commented Jun 25, 2020

Can we anticipate this fantastic feature in MM v4.20? 😊

@thoemmi
Copy link
Contributor

thoemmi commented Jun 25, 2020

I'm waiting for it too, as I'd like to customize it to show tags as well.

@mmistakes
Copy link
Owner

Finally got around to checking this out. Couple of small things then I think it's ready to merge in:

  • Adjust spacing between datetime and read time.

Screen Shot 2020-07-22 at 3 57 57 PM

The | doesn't have enough space between it and looks like it's part of the time. My suggestion would be to do something like <span class="sep"></span> instead. Then the following CSS which would allow someone to override the character and spacing easily without having to touch the _include.

.sep::before {
  content: "\2022";
  padding-left: 0.5em;
  padding-right: 0.5em;
}

Screen Shot 2020-07-22 at 4 04 01 PM

  • Add documentation about how to enable dates... perhaps before the Reading time config here.

  • Add a sample post with the date enabled similar to the reading time posts to show an example and for testing purposes.

@iBug
Copy link
Collaborator

iBug commented Jul 23, 2020

To give more details on @mmistakes' sensible suggestions, you'll want to add the following changes:

  • Replace your current separator (a plain vertical bar) with an empty span: <span class="sep"></span> and use the CSS ::before pseudo-element to fill in the content and set the spacing. You'll want to add mmistakes' sample CSS in _sass/minimal-mistakes/_page.scss, under the "Page meta" section, probably right before the next section "Page taxonomy" (the blank line at L301), as shown below.

    /*
    Page meta
    ========================================================================== */

  • Add documentation in docs/_docs/05-configuration.md. You can compose the docs in a way similar to the "Read time" paragraph. Just follow the styles and you're good to go. Don't forget to add a screenshot (you can simply add the one in mmistakes' comment).

    • You can even copy that paragraph and replace the content. IMO sentences, codes, etc. should remain the same, so just swap the keywords out and it'll be OK.
  • Sample post: Copy the one mmistake linked and change the front matter. You may consider creating two copies, one with only post date enabled, the other with both.

@limjh16
Copy link
Contributor Author

limjh16 commented Jul 23, 2020

Any reason why? I would think editing the yml file would be easier, especially since the breadcrumb_separator option is in there too

@iBug
Copy link
Collaborator

iBug commented Jul 23, 2020

The YAML file can't be edited in parts, which means you have to copy the whole file in order to override a single key. Using _config.yml would be even better, though I still prefer the CSS solution.

@limjh16
Copy link
Contributor Author

limjh16 commented Jul 23, 2020

Hmm, @mmistakes what do you think? It would be very simple to change it to use _config.yml and CSS anyways.

Also, I'm not really sure how you make the preview images, could you maybe help to make them? 😅

@iBug
Copy link
Collaborator

iBug commented Jul 23, 2020

A side note: It would be desirable to select-and-copy the full breadcrumb path including the separator, while it probably makes little sense to copy post date and reading time along with the separator. Using a CSS ::before pseudo-element makes sure it's not selectable (which is how CSS-based Font Awesome icons work).

@iBug
Copy link
Collaborator

iBug commented Jul 23, 2020

@limjh16 If you have Jekyll locally installed (along with Ruby and Bundler), you can run bundle exec jekyll serve in the docs directory, which will open up a development server at http://127.0.0.1:4000/minimal-mistakes/ for you to preview the whole docs site locally. You can then take the screenshots from your browser.

@iBug
Copy link
Collaborator

iBug commented Jul 23, 2020

AFAICT that's the built-in screenshot utility in macOS. For this specific PR I think it's fine to take a screenshot with whatever you have - you're not trying to illustrate the whole page layout after all.

@mmistakes
Copy link
Owner

I wouldn't worry about adding a screenshot. I think a description is clear enough what the feature is. Just as long as the documentation is there to explain how to toggle it on or off I'm cool.

It can always be improved later with a screenshot if needed.

@iBug
Copy link
Collaborator

iBug commented Jul 23, 2020

@mmistakes What about the implementation of the separator element? There have been 3 suggested in the thread:

  1. The current approach, using text from _data/ui-text.yml as a text node
  2. Similar to 1, but using text from _config.yml (probably with a default value) as a text node
  3. Use an empty inline element (e.g. <span>) and apply CSS on its ::before pseudo-element

My personal preference is 3 > 2 > 1, though any would be fine if it's easy enough to switch to 3 without overriding too many files (viva la CSS!).

@mmistakes
Copy link
Owner

mmistakes commented Jul 23, 2020

I prefer in the same order you proposed.

3. since that's the method I suggested 😉 and it keeps the separator text out of the markup since it's decoration and not necessarily content. Going the CSS path also adds way more flexibility if someone wants to change the separator in different context... (e.g. use a bullet on archive pages, use a pipe on post pages) which you can't do if it's hardcoded in the HTML.

2. Is fine and matches how title separators are treated. Advantage over 3, it's "easier" to change by the user as they don't need to override any CSS which tends to be a show stopper for many. Disadvantage, the separator is in the HTML markup and there's more Liquid bloat introduced in the templates.

1. Least desirable. Need to add a key for every language in the UI text data file versus a single key in _config.yml that's treated as a global variable.

@limjh16
Copy link
Contributor Author

limjh16 commented Jul 24, 2020

I have changed the customisation to a CSS implementation

Copy link
Collaborator

@iBug iBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I've examined locally and the CSS solution is flawless!

@iBug
Copy link
Collaborator

iBug commented Aug 1, 2020

@mmistakes This is looking perfect now (to me). Any chance you could take a look?

@mmistakes mmistakes merged commit f15e02e into mmistakes:master Aug 4, 2020
@tobiasvl
Copy link
Contributor

Thank you for this feature!

My page suddenly wouldn't build anymore (because I hadn't pinned a version number, it automatically used the latest version...), and after some digging I found out that the reason it broke was that read_time.html had been removed, which I used to – you guessed it – implement this exact functionality. Hehe.

👍

campjacob added a commit to campjacob/campjacob.github.io that referenced this pull request Aug 29, 2020
Was having errors due changes made in remote file. For now, will keep set at 4.19.3 due to stability.

mmistakes/minimal-mistakes#2526
the-physicist pushed a commit to the-physicist/universo-de-particulas that referenced this pull request Nov 8, 2020
O arquivo 'read-time.html" foi renomeado para "post__meta.httml" devido a uma atualização em Maio.

Checar <mmistakes/minimal-mistakes#2526>
@the-physicist
Copy link

I really liked it, you did a great job! Thank you.

mzaffran pushed a commit to mzaffran/mzaffran.github.io that referenced this pull request Jan 4, 2021
* add date to read-time.html

* add option for show_date, dynamic icon style

* change read-time to post__meta

* cleanup post__metal.html

* cleanup post__meta include variables

* put date before read time

* remove space in include variable

* allow customisation of post__meta separator

* add some documentation

* oops fix typo derp

* add post date image

* change page meta separator customisation to CSS
kaitokikuchi pushed a commit to kaitokikuchi/kaitokikuchi.github.io that referenced this pull request Sep 4, 2023
* add date to read-time.html

* add option for show_date, dynamic icon style

* change read-time to post__meta

* cleanup post__metal.html

* cleanup post__meta include variables

* put date before read time

* remove space in include variable

* allow customisation of post__meta separator

* add some documentation

* oops fix typo derp

* add post date image

* change page meta separator customisation to CSS
chukycheese pushed a commit to chukycheese/chukycheese.github.io that referenced this pull request Sep 18, 2023
* add date to read-time.html

* add option for show_date, dynamic icon style

* change read-time to post__meta

* cleanup post__metal.html

* cleanup post__meta include variables

* put date before read time

* remove space in include variable

* allow customisation of post__meta separator

* add some documentation

* oops fix typo derp

* add post date image

* change page meta separator customisation to CSS
arshad115 added a commit to arshad115/arshad115.github.io that referenced this pull request Feb 19, 2024
* Change tab indent to space for consistency (mmistakes#2614)

* Fix link for author name (mmistakes#2575)

Missed from bcd6126

* Update CHANGELOG and history

* Update zh-cn (mmistakes#2576)

* Update zh-cn
* Update ui-text.yml

* Update CHANGELOG and history

* Use layout: none instead of null (mmistakes#2617)

* Use layout: none instead of null

* Update CHANGELOG and history

* Configure entries layout `list` or `grid` (mmistakes#2616)

* Configure entries layout `list` or `grid`

This allows to use grid layout on `page.entries_layout` on the home layout.

Included a break since when using grid the post images are too close to the horizontal line bellow `posts` text.

There's a entries div now surrounding the posts since the first row of the grid was having a slight padding on the left. The home now behaves like posts/categories/tags pages with grid but including the paginator.

For best results on desktop use `classes: wide` and `paginate: 4` on `_config.yml` (or multiples of 4 if you want more rows)

* Fix indent

* Archive subtitle leaves space on the bottom

* Now space is added through style

* Update CHANGELOG and history

* Include documentation for home page grid view

* Update 10-layouts.md

* Update UI text for zh-CN and zh-TW (mmistakes#2626)

* Update UI text for zh-CN and zh-TW

* Update CHANGELOG and history

Not touching last_modified_at this time - it's messy enough

* Update documentation for mmistakes#2621 (mmistakes#2624)

* Update documentation for mmistakes#2621

* Update CHANGELOG and history

* Update last_modified_at

* remove hidden posts from `/posts` (mmistakes#2625)

* Update CHANGELOG and history

* Show date of posts (mmistakes#2526)

* add date to read-time.html

* add option for show_date, dynamic icon style

* change read-time to post__meta

* cleanup post__metal.html

* cleanup post__meta include variables

* put date before read time

* remove space in include variable

* allow customisation of post__meta separator

* add some documentation

* oops fix typo derp

* add post date image

* change page meta separator customisation to CSS

* Update CHANGELOG and history

* Fix grammar

* Remove extra back ticks

* Release 4.20.0 💎

* Update remote_theme

* Fix grammar

* Fix grid `entries_layout` in home.html

* Release 4.20.1 💎

* Update remote_theme version

* Fix `entries_layout: grid`
Close mmistakes#2639

* Update CHANGELOG and history

* Change "fa" to "fas" for Font Awesome 5 (mmistakes#2649)

* main.js: fa -> fas for FA 5

* Update CHANGELOG and history

* added css changes, modified jquery.greedy-navigation and built the main.min.js again

* Removed duplicated CSS definitions (mmistakes#2666)

* Update CHANGELOG and history

* Added article:author used by Pinterest (mmistakes#2670)

* Update CHANGELOG and history

* Refactor page meta (mmistakes#2641)

* Rename include

* Add grid view test pages

* Rename `.post__meta-sep` and use CSS to add line break

* Improve collection grid archive

* Improve page grid archive

* Enable `grid`

* Don't show date icon if there is no `date` value

* Add blank line at EOF

* Add space

* Wrap date and reading time in named `span` elements

* Update CHANGELOG and history

* Bump copyright year

* Fix typo

Close mmistakes#2678

* Fix broken link in documentation

Close mmistakes#2677

* Release 4.20.2 💎

* Bump theme version

* Update allejo/jekyll-toc to v1.0.14

https://github.com/allejo/jekyll-toc/releases/tag/v1.0.14

* Fix dead link to "CI services" Jekyll (mmistakes#2692)

* Fix mmistakes#2635

* Update CHANGELOG and history

* Update README.md

* Update CONTRIBUTING.md

* Update stale.yml

* Fix closing tag of figures without captions in lists (mmistakes#2697)

When the figure helper is used in a list, which can be either ordered or
unordered, and no caption is specified, a line with text "</figure>"
will be shown below the figure on the rendered page.

This is because, if the '{% if include.caption %}' evaluates to false,
the lines between that 'if' statement and '{% endif %}' will be emptied,
not removed, so the block will be filled by empty lines.

HTML ignores redundant empty lines, but Markdown takes them seriously.
In addition, Markdown expects proper indentation of lines inside lists,
and the closing '</figure>' tag is not indented.  When combined, the
empty space and absence of indentation cause Markdown to process the
'</figure>' tag as a separate paragraph instead of an HTML tag, thus the
text for the tag is directly rendered on the page.

The fix for this issue is very simple: remove the empty space when
'include.caption' is false.  As described in
<https://shopify.github.io/liquid/basics/whitespace/>, this can be done
by adding hyphens to the 'if' and 'endif' tags.

* Update CHANGELOG and history

* Update CHANGELOG and history

* Norwegian translation (mmistakes#2702)

* Update CHANGELOG and history

* Update CHANGELOG and history

* Fix a small typo in documentation

* Update ui-text.yml for Vietnamese

* Added some translation for indonesian language

* Update indonesian translation

* Update CHANGELOG and history

* Update CHANGELOG and history

* Update jQuery to 3.5.1 (mmistakes#2713)

* Update jQuery to 3.5.1

Closes mmistakes#2712

* Build NodeJS

Run using `npm run build:js`

* Update CHANGELOG and history

* Release 4.21.0 💎

* Update `remote_theme` version

* Fix heading level

* Fix Font Awesome icon color in various skins

Close mmistakes#2724

* Update remote theme instructions

* jekyll-install-cache gem should be added to Gemfile

* Update CHANGELOG and history

* indonesian translation minor typo fix (mmistakes#2731)

* Update CHANGELOG and history

* Update 404.md (mmistakes#2737)

Removed Google Search script which no longer worked.
mmistakes#2597

* Update CHANGELOG and history

* Delete support.md

* Delete feature_request.md

* Update allejo/jekyll-toc to v1.1.0, skip headings without an ID (mmistakes#2752)

* Update allejo/jekyll-toc to v1.1.0, skip headings without an ID

https://github.com/allejo/jekyll-toc/releases/tag/v1.1.0

* Update CHANGELOG and history

* Add toc_sticky parameter's description (mmistakes#2741)

* Update CHANGELOG and history

* Fix typo

* Add hebrew translation (mmistakes#2760)

* Update CHANGELOG and history

* Add .webp to supported lightbox images (mmistakes#2788)

* Update CHANGELOG and history

* Remove google's fixurl.js from example (mmistakes#2789)

Unfortunately, it no longer exists.

* Update CHANGELOG and history

* Upgrade Lunrjs to 2.3.9 and switch to relative_url (mmistakes#2805)

* Update Lunr to 2.3.9

* Switch from absolute_url to relative_url

* Update CHANGELOG and history

* Allow custom gradient in page header overlays (mmistakes#2806)

* Allow custom gradient in page header overlays

* Update documentation

* Update CHANGELOG and history

* Add toggle option for RSS feed visibility (mmistakes#2787)

* add a "hide" value in config for atom

* Update footer to use param

* update header to use param

* Update docs to note configuration

* undo formatting

* use unless syntax

* unless syntax and indentation

* indentation

* Update CHANGELOG and history

* Use sort_natural instead of custom-logic (mmistakes#2756)

* Update CHANGELOG and history

* Allow custom sorting for collections (mmistakes#2723)

* Allow custom sorting for collections

* Update docs with custom sort of collections

* Refactoring

* Update CHANGELOG and history

* Release 4.22.0 💎

* Update

* Force rebuild of demo site

* Fix typos

* Remove G-stuff CSS (mmistakes#2852) (mmistakes#2855)

* Add alt attr to site logo in masthead (mmistakes#2824)

Co-authored-by: Michael Rose <mmistakes@users.noreply.github.com>

* Add note on TOC heading level issue (mmistakes#2902)

mmistakes#2892 (comment)

* Add Baidu site verfication (mmistakes#2830)

* Update CHANGELOG and history

* Remove all references to official public Staticman API instance. (mmistakes#2831)

* Updated Staticman docs

* remove any ref to official public instance in docs

* remove fallback instance for staticman v2

left staticman v1 untouched as I dunno how to deal with that

* Update CHANGELOG and history

* Datetime format (mmistakes#2844)

* datetime_format

* page__meta

* page__date

* page__date test

* update docs

* update docs

* Update CHANGELOG and history

* Color notices based on skin colors instead of fixed values (mmistakes#2887)

* Made notice Sass color mixing in based on $background-color and $text-color instead of hard-coded black and white values.

* Made some style adjustments to notices to improve readability.

Notice links are slightly darkened from the notice color, mostly because the gray-on-gray default notice links were very hard to read.  Rather than being $notice-color, they are `mix(#000, $notice-color, 10%)`.
The notice background mix and code-background mix can now be set with the SCSS variables $notice-background-mix and $code-notice-background-mix.
The default mix for background was adjusted to 80%, from 90%.
The default mix for code-background was adjusted to 90%, from 95%.
Skins that still didn't read well were adjusted individually.

* Adjusted sunrise $notice-background-mix to 75%

* Adjusted dark theme notice background mix colors back to the default

Co-authored-by: Tom Manner <tsmanner@us.ibm.com>

* Update CHANGELOG and history

* Document user custom element hooks (mmistakes#2815)

* Added documentation for including custom CSS on a site or page

* Removed non-configuration related content from 05-configuration.md and cleaned up some style in new sections of 16-stylesheets.md

* Moved small custom head documentation to a ProTip in _docs/06-overriding-theme-defaults.md

* Cleaned up some documentation, and added some example uses of custom head and footer.

* Replace double space with single

* Replace double spaces with single

Co-authored-by: Tom Manner <tsmanner@us.ibm.com>
Co-authored-by: Michael Rose <mmistakes@users.noreply.github.com>

* Update CHANGELOG and history

* Add Arabic Translation 📝

* Update onchange and uglify-js dependencies

* Fix typo

* Update

* Update 14-helpers.md (mmistakes#2940)

Fix missing backtick.

* Update CHANGELOG and history

* Fix Jekyll environment note in configuration documentation

Close mmistakes#2912

* Fix typo

Close mmistakes#2911

* Update stale action

* Update stale.yml

* FIx menu toggle

ref: mmistakes#2957

* Release 4.23.0 💎

* Update CHANGELOG and history

* Bump theme version

* Enable auto ads

* Update Google Adsense

* Update FUNDING.yml

* Update FUNDING.yml

* Update README.md

* Disable auto ads

* Update support buttons

* Update Adsense

* Add banner above related posts

* Update FUNDING.yml

* Update FUNDING.yml

* Fix broken image

Close mmistakes#3013

* feat: Search icon in masthead is a Font Awesome icon. (mmistakes#2774)

* feat: Allow search icon in masthead to be set to a Font Awesome icon.

* fix indentations

* Users wishing to avoid FontAwesome should override _includes/masthead.html

* Update CHANGELOG and history

* Loads font-awesome asynchronously (mmistakes#2967)

Loading font-awesome asynchronously allows to display the site faster. This change is advised by google pagespeed insights

* Update CHANGELOG and history

* Remove H2 as it is not important to site structure (mmistakes#3012)

This should not use a H2, as that is not an important headline, and thus a H2 here would probably hurt in page SEO.

* Update CHANGELOG and history

* Fix broken links in documentation

Close mmistakes#3004

* Remove `tabindex="-1"` from `input` elements in `search.html` layout

Make `input` elements accessible by keyboard.

Fixes mmistakes#2982

* Update README text for Gumshoejs license (mmistakes#3024)

* Update CHANGELOG and history

* Remove IE9 flexbox fallback (mmistakes#3042)

IE9 is absolutely, completely, totally dead. it's marketshare is less than 0.1%.
REF: https://caniuse.com/usage-table

Save some bytes in the HTML for all users by removing the fallback inline CSS.

* Update CHANGELOG and history

* Add giscus support (mmistakes#3022)

* Add script in same style as utterances

But adjusted for the various filed differences

* Add initial script

* Add default settings

* Update changelog

* Add feature to readme

* Add comments html

* add comment provider include

* update config in docs

* Add URL for additional reference

* docs for giscus comments

* Unrelated bugfix: add missing version separator

So that things match the "history" doc.

* add space

* update history doc

* update about doc

* add to test config yaml

* remove unnecessary / incorrect async attribute

* probably should pass the right config paths

* lowercase the repo name

* Update docs to address '1' and '0' for reactions_enabled

Figured I'd match the giscus format rather than convert a boolean to an int there.

* update two additional docs

* docs wording fix

* Release 4.24.0 💎

* Update version

* Remove site.url from first breadcrumb link (mmistakes#3051)

* Remove site.url from first breadcrumb link

Fixes mmistakes#3050

* Use relative_rul filter instead of site.baseurl

* Update CHANGELOG and history

* Fixed a grammar error in the german translation (mmistakes#3063)

* Update CHANGELOG and history

* fix: change heading tag of related posts section from `h4` to `h2` for SEO enhancement (mmistakes#3064)

* Update heading tag from `h4` to `h2`

* Update heading tag from `h4` to `h2`

* Update CHANGELOG and history

* Add instructions on how to unminify main.js for easier browser debugging (mmistakes#3055)

* Add instructions on how to unminify main.js for easier browser debugging

* Fixed Markdown style like sggested by @iBug

* Update CHANGELOG and history

* Make small grammar changes

* Update 01-quick-start-guide.md

* Add Microformats (mmistakes#3052)

* Add rel=me to author profile links

* Add h-card Microformats markup

* Add h-entry microformat markup

* Fix missing anchor tag

* Fix h-entry microformat markup on single template

* Use minimal subset of Microformat elements

* Move dt-published to `page__date.html` and remove dt-updated
* Remove "author" and "summary"

Leaves "url" as a hidden element

* Add page link to h1 tag

The h1 tag now contains the Schema-org `url` itemprop and the
Microformats `url` class in an anchor tag.  The anchor tag is styled to
not look like a link.

* Put author 'u-url' on author__name h3

This also puts the same `{{ author.home | default: '/' | absolute_url }}`
construct on `author__avatar` to remove the Jekyll `author.home`
conditional.

Also addresses SCSS text color error.

* Update CHANGELOG and history

* Enable toc sidebar scrolling (mmistakes#2874)

* Enable toc sidebar scrolling

* Refactor style rules

* Move style rules from 'navigation' to 'sidebar'

* Remove custom scrollbar styles

* Enable sticky toc on test post

* Update CHANGELOG and history

* Add margin around Google ads

* Add role to search (mmistakes#3086)

* Update CHANGELOG and history

* Added Danish translations (mmistakes#3095)

* Added Danish translations

* Fixed wrong commit.

* Update CHANGELOG and history

* Enable magnific popup on <a> tags only when it has <img> (mmistakes#3114)

* Update CHANGELOG and history

* Remove extra semi-colon

* Bump path-parse from 1.0.6 to 1.0.7

Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update CHANGELOG and history

* include video does not survive compress.html (mmistakes#3117)

* Update CHANGELOG and history

* Use GitHub issue templates (mmistakes#3133)

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository

* Delete stale.yml

* Delete stale.yml

* Added optional label attribute (mmistakes#3128)

Added label attribute as per utterances optional label setting.

* Fix broken link & Add Baidu site verification (mmistakes#3139)

* Fix broken link
Link to Bing Webmaster Tools was broken.

* Fix broken link
Link to Open Graph debug tool was broken.

* Add Baidu site verification (mmistakes#2830)
Added `baidu_site_verification` to `_config.yml`

* Making verbiage consistent w/current _config.yml (mmistakes#3180)

The plugin in question comes by-default listed in _config.yml ; it's better to say that the user must _retain_ it as listed, not that the user needs to add it.

* Link clarifying adding plugins (mmistakes#3181)

The phrase "put them here!" doesn't sufficiently clarify what to do; I add link to the Jekyll documentation with the proper syntax.

* feat: Sort comments by date ascending (mmistakes#3184)

* Update Brazilian Portuguese translation (mmistakes#3204)

* Update Brazilian Portuguese translation

* Revert some translations to reduce friction

* Update CHANGELOG and history

* Update CHANGELOG and history

* Fix keybase class (mmistakes#3221)

* Fix keybase class

* Fix fas->fab

* Update CHANGELOG and history

* ✏ fix typo (mmistakes#3232)

* Update CHANGELOG and history

* Add missing comma (mmistakes#3318)

Co-authored-by: Yuchen Zhong <yuchen21@fb.com>

* Update CHANGELOG and history

* Automatically close invalid PRs using GitHub Actions (mmistakes#3313)

* Try auto-closing bad PRs

* Include empty PR body as well

* Add "Type: Invalid" label as well

* Update CHANGELOG and history

* Added sameAs (mmistakes#3087)

* Update CHANGELOG and history

* Use <a> color for blockquote.notice border (mmistakes#3140)

Close mmistakes#3068

* Update CHANGELOG and history

* Fix inline code style not applied to stylized text (mmistakes#3253)

* bug: inline code style not applied to stylized text

* Use double colons for pseudoelements

* Update CHANGELOG and history

* Update to Jquery 3.6.0 (mmistakes#3254)

* Update CHANGELOG and history

* fix typo about loading javascript in footer (mmistakes#3350)

* Update CHANGELOG and history

* add optinal lunr searching of pages (mmistakes#3352)

* Update CHANGELOG and history

* Exclude `main.scss` from Lunr search index

* Add Kiswahili translation (mmistakes#3489)

* Add Kiswahili translation

* Add Kiswahli to README

* Add Kiswahili to documentation

* Update

* Update attribution link (mmistakes#3553)

* Update CHANGELOG and history

* Update link to Font Awesome gallery (mmistakes#3599)

* Update CHANGELOG and history

* Make it possible to enable breadcrumbs per page (mmistakes#3096)

* Make it possible to disable breadcrumbs per page

* Update single.html

* Update single.html

* Update algolia-search-scripts.html (mmistakes#3102)

Fix issue mmistakes#3101

* Update CHANGELOG and history

* Replace with public YouTube video

Close mmistakes#3649

* Replace with public YouTube video embeds

* Update CHANGELOG and history

* Fix mmistakes#3096 enabling breadcrumb on all pages (mmistakes#3668)

* Remove IE9 upgrade notice (mmistakes#3666)

* Update CHANGELOG and history

* Fix mmistakes#3668 breaking "disable per-page when globally enabled" (mmistakes#3669)

* Fix mmistakes#3668 breaking "disable per-page when globally enabled"

* `default:` filter doesn't fit here

https://shopify.github.io/liquid/filters/default/

* Update CHANGELOG and history

* Improve PR close auto-comment message (mmistakes#3713)

* Improve auto-comment message

* Lock these PRs after closing

* add webrick

* whatever, line ending perhaps

* bug fix

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: iBug ♦ <git@ibugone.com>
Co-authored-by: dianlujitao <dianlujitao@gmail.com>
Co-authored-by: Michael Rose <est.michael@gmail.com>
Co-authored-by: 谭九鼎 <109224573@qq.com>
Co-authored-by: Juan Ara <juan@juanylaura.es>
Co-authored-by: Michael Rose <mmistakes@users.noreply.github.com>
Co-authored-by: Andrey Kartashov <gorilych@gmail.com>
Co-authored-by: Lim Jing Heng <limjh16@gmail.com>
Co-authored-by: Miguel Belardinelli Prytoluk <prytolukster@gmail.com>
Co-authored-by: Johannes Ganzenmüller <jganzenmller@ebay.com>
Co-authored-by: Lars Olesen <lars@intraface.dk>
Co-authored-by: Leo <liaoyuan@gmail.com>
Co-authored-by: Kai A <kai.andresen@gmail.com>
Co-authored-by: Quan <8580008+quanengineering@users.noreply.github.com>
Co-authored-by: M. Akhyar Rahman H <akhyarrh@users.noreply.github.com>
Co-authored-by: Mitchell Skaggs <skaggsm333@gmail.com>
Co-authored-by: Susan Stevens <susan.stevens10@gmail.com>
Co-authored-by: Jip-Hop <Jip-Hop@live.nl>
Co-authored-by: gricn <gricn666@gmail.com>
Co-authored-by: Uri Brecher <uri.brecher@gmail.com>
Co-authored-by: PHOENiX <rlaphoenix@pm.me>
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
Co-authored-by: Johannes Ganzenmüller <johannes.ganzenmueller@gmail.com>
Co-authored-by: Nicolas Elie <40382614+n-elie@users.noreply.github.com>
Co-authored-by: luweizheng <luweizheng36@hotmail.com>
Co-authored-by: Vincent Tam <VincentTam@users.noreply.github.com>
Co-authored-by: Tom Manner <zephrincochrane@gmail.com>
Co-authored-by: Tom Manner <tsmanner@us.ibm.com>
Co-authored-by: ShifraSec <48570596+MoElaSec@users.noreply.github.com>
Co-authored-by: David Lechner <david@lechnology.com>
Co-authored-by: Randall Wood <297232+rhwood@users.noreply.github.com>
Co-authored-by: Guillaume Gautreau <guillaume+github@ghusse.com>
Co-authored-by: Christian Oliff <christianoliff@pm.me>
Co-authored-by: Erik Westrup <erik.westrup@gmail.com>
Co-authored-by: Anton Brall <github@antonbrall.de>
Co-authored-by: Kulbhushan Chand <17742733+kulbhushanchand@users.noreply.github.com>
Co-authored-by: Peter Murray <jester@dltj.org>
Co-authored-by: Johnson <20457146+j3soon@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Scott <68079471+JohnScottUK@users.noreply.github.com>
Co-authored-by: Nathan Cho <ntcho13@gmail.com>
Co-authored-by: Jason Hemann <jason.hemann@gmail.com>
Co-authored-by: Daniel Schroeder <deadlydog@hotmail.com>
Co-authored-by: Georger Araújo <4930759+georgeraraujo@users.noreply.github.com>
Co-authored-by: Andrew McIntosh <amcintosh@users.noreply.github.com>
Co-authored-by: Sander Holvoet <holvoetsander@gmail.com>
Co-authored-by: Yuchen <yzhong52@users.noreply.github.com>
Co-authored-by: Yuchen Zhong <yuchen21@fb.com>
Co-authored-by: Nicholas Perry <ape.inago@gmail.com>
Co-authored-by: Benson Muite <bkmgit@users.noreply.github.com>
Co-authored-by: FavorMylikes <FavorMylikes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants