Update video #2512
Merged
Update video #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support bilibili video
iBug
requested changes
May 1, 2020
_includes/video
Outdated
| @@ -9,5 +9,9 @@ | |||
| <iframe src="https://www.youtube-nocookie.com/embed/{{ video_id }}" frameborder="0" allowfullscreen></iframe> | |||
| {% elsif video_provider == "google-drive" %} | |||
| <iframe src="https://drive.google.com/file/d/{{ video_id }}/preview" frameborder="0" allowfullscreen></iframe> | |||
| {% elsif video_provider == "bilibili" %} | |||
| <div class="responsive-video-container"> | |||
There was a problem hiding this comment.
There's already a <div class="responsive-video-container"> surrounding the whole if statement. Might be better to drop this duplicated <div> wrapper,
There was a problem hiding this comment.
Yes. You're right. I have deleted the duplicated <div> wrapper.
drop the duplicated <div> wrapper
iBug
requested changes
May 1, 2020
_includes/video
Outdated
| @@ -9,5 +9,7 @@ | |||
| <iframe src="https://www.youtube-nocookie.com/embed/{{ video_id }}" frameborder="0" allowfullscreen></iframe> | |||
| {% elsif video_provider == "google-drive" %} | |||
| <iframe src="https://drive.google.com/file/d/{{ video_id }}/preview" frameborder="0" allowfullscreen></iframe> | |||
| {% elsif video_provider == "bilibili" %} | |||
| <iframe src="//player.bilibili.com/player.html?bvid={{ video_id }}&page=1&as_wide=1&high_quality=1&danmaku=0" scrolling="no" border="0" frameborder="no" framespacing="0" allowfullscreen="true"> </iframe> | |||
There was a problem hiding this comment.
Another suggestion: Add https: before the URL so it stays in line with other items in the same list.
- <iframe src="//player.bilibili.com/player.html?bvid={{ video_id }}&page=1&as_wide=1&high_quality=1&danmaku=0" scrolling="no" border="0" frameborder="no" framespacing="0" allowfullscreen="true"> </iframe>
+ <iframe src="https://player.bilibili.com/player.html?bvid={{ video_id }}&page=1&as_wide=1&high_quality=1&danmaku=0" scrolling="no" border="0" frameborder="no" framespacing="0" allowfullscreen="true"></iframe>update video
iBug
approved these changes
May 1, 2020
jesuswasrasta
pushed a commit
to jesuswasrasta/jesuswasrasta.github.io
that referenced
this pull request
Jul 8, 2020
* Update video support bilibili video * Update video drop the duplicated <div> wrapper * Update video update video
mzaffran
pushed a commit
to mzaffran/mzaffran.github.io
that referenced
this pull request
Jan 4, 2021
* Update video support bilibili video * Update video drop the duplicated <div> wrapper * Update video update video
kaitokikuchi
pushed a commit
to kaitokikuchi/kaitokikuchi.github.io
that referenced
this pull request
Sep 4, 2023
* Update video support bilibili video * Update video drop the duplicated <div> wrapper * Update video update video
chukycheese
pushed a commit
to chukycheese/chukycheese.github.io
that referenced
this pull request
Sep 18, 2023
* Update video support bilibili video * Update video drop the duplicated <div> wrapper * Update video update video
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support insert bilibili video
This is an enhancement or feature.
Summary
Support insert bilibili video in the posts.
How to insert bilibili video?
Replace
videoIDwith the bvid of the video you want to post.