Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify lunr only searches documents in collections #2450

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

at-ishikawa
Copy link
Contributor

This is a documentation change.

Summary

Update documents to clarify Lunr only searches documents in collections or posts.

Context

I'm newbie of jekyll and github pages, and I couldn't figure out why my pages under /docs directories cannot be searched for a couple of hours.
So, I think it's gonna be great if we explicit say documents in collections can be searched, so that newbies can understand.

Is this related to any GitHub issue(s)?

It looks this PR is related with #1663 (comment)

@at-ishikawa
Copy link
Contributor Author

@mmistakes Thank you for adding label.
I force-pushed my commit in order to fix my professional email/name to my personal name/email.
Can you take a look again?

Also, if this PR looks good, what should we do for next?
It seems I can't merge the PR, so will you merge it if this PR looks good?

@mmistakes
Copy link
Owner

Nothing to do on your end. I just need time to merge it in and update the change log/history.

@mmistakes mmistakes merged commit def3aaf into mmistakes:master Mar 23, 2020
@at-ishikawa at-ishikawa deleted the update-search-configuration branch March 23, 2020 21:03
jesuswasrasta pushed a commit to jesuswasrasta/jesuswasrasta.github.io that referenced this pull request Jul 8, 2020
mzaffran pushed a commit to mzaffran/mzaffran.github.io that referenced this pull request Jan 4, 2021
kaitokikuchi pushed a commit to kaitokikuchi/kaitokikuchi.github.io that referenced this pull request Sep 4, 2023
chukycheese pushed a commit to chukycheese/chukycheese.github.io that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants