Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vimeo fails to play when served over HTTPS #944

Closed
ghost opened this issue Apr 10, 2017 · 0 comments · Fixed by #945
Closed

Vimeo fails to play when served over HTTPS #944

ghost opened this issue Apr 10, 2017 · 0 comments · Fixed by #945
Labels
Type: Bug

Comments

@ghost
Copy link

ghost commented Apr 10, 2017

#788 introduced video URLs with hard-coded scheme. These need to be made protocol-relative for proper support over HTTPs.
@ghost ghost mentioned this issue Apr 10, 2017
Merged
mmistakes pushed a commit that referenced this issue Apr 19, 2017
@mmistakes
fix(includes/video): use https always (#945)
706531b 
closes #944
RobinYu added a commit to RobinYu/robinyuuu.github.io that referenced this issue May 8, 2017
@RobinYu
fix(includes/video): use https always (mmistakes#945)
be9e104 
closes mmistakes#944
kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this issue May 30, 2019
@mmistakes
fix(includes/video): use https always (mmistakes#945)
8ff2bba 
closes mmistakes#944
makaroniame added a commit to makaroniame/makaroniame-old.github.io that referenced this issue May 18, 2022
@makaroniame
fix(includes/video): use https always (mmistakes#945)
3d259bd 
closes mmistakes#944
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this issue May 5, 2023
@mmistakes
fix(includes/video): use https always (mmistakes#945)
781907f 
closes mmistakes#944
koyumi0601 pushed a commit to koyumi0601/koyumi0601.github.io that referenced this issue Jul 31, 2023
@alyssais @mattxwang
Improve display of AsciiDoc examples with titles (mmistakes#944)
e03483d 
The jekyll-asciidoc plugin will take AsciiDoc markup like this:

	.A method that returns the string "Hello, world"
	[example]
	[source,ruby]
	----
	def hello
	  "Hello, world"
	end
	----

And produce HTML like this (syntax highlighting disabled):

	<div class="listingblock">
	  <div class="title">A method that returns the string "Hello, world"</div>
	  <div class="content">
	    <pre class="highlight"><code class="language-ruby" data-lang="ruby">def hello
	  "Hello, world"
	end</code></pre>
	  </div>
	</div>

Previously, because we were applying code block styling to the whole
listingblock, the title would be rendered as normal body text, inside
the code block, which did not look good.  With this change, it will
instead be rendered similarly to a Just The Docs rendered example —
the title will appear where the rendered example usually would.

Co-authored-by: Matt Wang <matt@matthewwang.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(includes/video): use https always
1 participant
@mmistakes