Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use last_modified_at instead of or in addition to modified? #929

Closed
3 of 5 tasks
swsnr opened this issue Apr 3, 2017 · 2 comments
Closed
3 of 5 tasks

Use last_modified_at instead of or in addition to modified? #929

swsnr opened this issue Apr 3, 2017 · 2 comments
Labels
Type: Enhancement

Comments

@swsnr
Copy link
Contributor

swsnr commented Apr 3, 2017

  • This is a question about using the theme.
  • This is a feature request.
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.
  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.

Minimal Mistakes uses the modified property of a page for the "Updated:" footer in single layout. However, jekyll-feed uses last_modified_at which can be set automatically by a Jekyll plugin.

So, currently I have to set both "modified" and "last_updated_at" if I'd like to have correct dates on the page as well as in the atom feed.

Would it be possible for Minimal Mistakes to use "last_updated_at" instead of or in addition to "modified"?
@mmistakes
Copy link
Owner

Good suggestion. I made the switch to last_modified_at recently on my personal site for this exact reason. Total meant to update MM to user it to. Thanks for the reminder!

@swsnr swsnr mentioned this issue Apr 4, 2017
Merged
@swsnr
Copy link
Contributor Author

swsnr commented Apr 4, 2017

@mmistakes Thanks. I made #930 to replace modified with last_modified_at :)

mmistakes pushed a commit that referenced this issue Apr 4, 2017
@swsnr @mmistakes
Replace modified with last_modified_at (#930)
cf4f827 
Fixes #929
RobinYu added a commit to RobinYu/robinyuuu.github.io that referenced this issue May 8, 2017
@RobinYu
Replace modified with last_modified_at (mmistakes#930)
d8517ad 
Fixes mmistakes#929
@mmistakes mmistakes mentioned this issue Jul 5, 2017
Closed
kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this issue May 30, 2019
@swsnr @mmistakes
Replace modified with last_modified_at (mmistakes#930)
a394dbc 
Fixes mmistakes#929
makaroniame added a commit to makaroniame/makaroniame-old.github.io that referenced this issue May 18, 2022
@makaroniame
Replace modified with last_modified_at (mmistakes#930)
7330465 
Fixes mmistakes#929
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this issue May 5, 2023
@swsnr @mmistakes
Replace modified with last_modified_at (mmistakes#930)
ea5a8b6 
Fixes mmistakes#929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swsnr @mmistakes