Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Insert() and Remove() #151

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Fix Insert() and Remove() #151

merged 1 commit into from
Mar 15, 2024

Conversation

Banaanae
Copy link
Collaborator

@Banaanae Banaanae commented Mar 15, 2024

Still needs:

  • Fix Key-Value pairs
  • Handling vars (a var will fail IsDigit())
  • Handling cases that don't match if statements
  • Lots of warnings ;-;

key-value pairs need work
and warnings
@mmikeww
Copy link
Owner

mmikeww commented Mar 15, 2024

Feel free to take initiatives on things like this. Having the suite of tests allows experimentation because you can easily see if you introduce any regressions that would break other functionality. As long as tests pass, incremental additions should be fine

@Banaanae Banaanae marked this pull request as ready for review March 15, 2024 07:42
@Banaanae
Copy link
Collaborator Author

Right, the warnings only show when converting Insert and Remove so should be fine for now

@Banaanae Banaanae merged commit 98f7363 into mmikeww:master Mar 15, 2024
@Banaanae Banaanae deleted the 6Properties branch March 15, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants