Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"" -> `" more conversion errors #253

Closed
Banaanae opened this issue Jul 14, 2024 · 1 comment · Fixed by #259
Closed

"" -> `" more conversion errors #253

Banaanae opened this issue Jul 14, 2024 · 1 comment · Fixed by #259

Comments

@Banaanae
Copy link
Collaborator

V1:

var2 = failing
var := "MyTest = """ var2 """"
var3 := "MyTest = """ var2 """>"

MsgBox % var
MsgBox % var3

V2 (Converted):

var2 := "failing"
var := "MyTest = """ var2 "`""
var3 := "MyTest = "`" var2 `"">"

MsgBox(var)
MsgBox(var3)

V2 (Expected):

var2 := "failing"
var := "MyTest = `"" var2 "`""
var3 := "MyTest = `"" var2 "`">"

MsgBox(var)
MsgBox(var3)

From: https://www.autohotkey.com/boards/viewtopic.php?f=82&p=578811
Used this RegEx (fixed var; breaks more tests however)

@andymbody
Copy link
Contributor

Got this covered... submitting fix shortly...

andymbody added a commit to andymbody/AHK-v2-script-converter that referenced this issue Jul 15, 2024
Banaanae added a commit that referenced this issue Jul 16, 2024
240715_ AMB - Fix #253 - quotes within quoted string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants