Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to @react-native-community/react-native-datetimepicker #299

Closed
wants to merge 15 commits into from

Conversation

mmazzarolo
Copy link
Owner

This PR was previously available at #262

This PR captures the work needed to migrate to the new @react-native-community/react-native-datetimepicker.

Setup:

  • Added @react-native-community/react-native-datetimepicker
  • Updated the dependencies
  • Updated the example

IOS:

  • Implemented @react-native-community/react-native-datetimepicker
  • Simplified the API, removed a few style props (users can still supply their own version of the header/buttons)
  • Find a workaround to this RN issue, easily reproducible by touching the picker without changing the selected value
  • Moved out of react-native-modal

Android:

  • Implemented @react-native-community/react-native-datetimepicker
  • Simplified the API

Docs:

  • Update README.md

Deprecated props:
A few prop names are going to be changed (the old name will still work though).
titleIOS → headerTextIOS
customTitleContainerIOS → customHeaderIOS
onHideAfterConfirm → onHide
customDatePickerIOS → customPickerIOS

Breaking changes:
The following props are not supported anymore:

  • cancelTextStyle → Please use customCancelButtonIOS to override the component instead
  • confirmTextStyle → Please use customConfirmButtonIOS to override the component instead
  • datePickerModeAndroid → Please use the display prop of @react-native-community/react-native-datetimepicker instead
  • dismissOnBackdropPressIOS → This is now the default behaviour on iOS
  • hideTitleContainerIOS → Please set customHeaderIOS to null instead
  • neverDisableConfirmIOS→ This behaviour was causing a few issues with the new picker
  • pickerRefCb→ Not supported by the new picker
  • reactNativeModalPropsIOSreact-native-modal is not being used anymore

@mmazzarolo mmazzarolo changed the title Next Migrate to @react-native-community/react-native-datetimepicker Oct 17, 2019
@mmazzarolo mmazzarolo closed this Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant