Make Button label prop type required #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As there is `label: PropTypes.string.isRequired`
|
Also, I would change react-native-dialog/src/Button.tsx Line 26 in 4ba0202 to const DialogButton = (props: DialogButtonProps): JSX.Element => { ... }to avoid passing children to it, as I did by mistake. I ain't doing it in a PR as you may not like it. |
Let's wait for this, we're also planning to do a refactroing |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
## [9.1.1](v9.1.0...v9.1.1) (2021-09-30) ### Bug Fixes * Make Button label prop type required ([#123](#123)) ([e096d6b](e096d6b))
|
🎉 This PR is included in version 9.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As there is
react-native-dialog/src/Button.tsx
Line 57 in 4ba0202
Test Plan