Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct __cxa_atexit function definition #293

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Use correct __cxa_atexit function definition #293

merged 1 commit into from
Aug 7, 2023

Conversation

domenukk
Copy link
Contributor

@domenukk domenukk commented Aug 7, 2023 •
edited
Loading

This probably doesn't change much, but the __cxa_atexit function takes one (void *) parameter, see LSB or
cxa_atexit_callback in the darwin-crt:

typedef void (*cxa_atexit_callback)(void *);

mmastrac
mmastrac approved these changes Aug 7, 2023
View reviewed changes
Copy link
Owner

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mmastrac mmastrac merged commit 3c8372b into mmastrac:master Aug 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domenukk @mmastrac