Fixed and simplified #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed some Bugs - Works now on Border Crystals
simplyfied code and increased maintainability
…sing. Total bagcount gets guessed by then Further testing necessary.
8-bag-bug fixed
mluzarow
reviewed
Mar 11, 2020
| local IngredientCount = 0 | ||
| local OldIngredientCount = 0 | ||
|
|
||
| function sendMethMessage(number, id) |
There was a problem hiding this comment.
Can we clean this up slightly so it has less repetition?
MessageColor = Color.green;
if number == 1 then
Message = 'Ingredient added!';
elseif number == 2 then
Message = '[' .. countAddedIngredients(currentRecipeList) .. '/3] [' .. ingredient_dialog[id] .. ']';
elseif number == 3 then
Message = 'Total bags: [' .. totalBags .. ']';
elseif number == 4 then
Message = 'No finished dialouge caught, Bag-count is being guessed by now';
MessageColor = Color.red;
else
return;
end
if MethHelper._data.silent_toggle == true or MethHelper._data.silent_toggle == 'on' then
managers.chat:_receive_message(1, '[SilentMethMagic]', Message, MessageColor);
else
managers.chat:send_message(1, '[SilentMethMagic]',Message, MessageColor);
end(I feel like thats easier to understand)
| if id == CookoffFinishedID or id == RatsFinishedID or id == BorderCrystalFinsishedID or id == BorderCrystalFinsishedID2 then | ||
| -- If "ingredient added" dialogue is played | ||
| if isMethFinished(id) == true then | ||
| -- If "BAg finished" dialogue is played |
Fixed wrong methcounter on border crystals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed Stop working after 8 bag in cook off #8