PCG random number generator #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an optional drop-in replacement for C++'s Mersenne Twister. See https://www.pcg-random.org/ for more information.
SHervoe-Hansen
requested review from
SHervoe-Hansen
and removed request for
SHervoe-Hansen
There was a problem hiding this comment.
The PCG RNG looks amazing from the material linked in the PR.
However given that in mind I think we should set the value to default and perhaps also update the documentation in case one attempts to reproduce results given a specific RNG.
Furthermore multiple tests returned
could not initialize random engine - falling back to fixed seed.
Is this related to the PCG?
mlund
changed the title
Yes, the state is specific to the engine, but I think the message explanation is OK'ish. If we set PCG to default we should update (or remove) the state-info from the state files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optional drop-in replacement for C++'s Mersenne Twister. See https://www.pcg-random.org/ for more information.