Fix speciation check for full or empty groups #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where product and reactants could be wrongly activated even if the groups are full/empty. This is a problem important only when simulating at extreme conditions where the groups are almost empty or almost full.
mlund
changed the title
mlund
changed the title
mlund
changed the title
|
@rc83 cherry pick this commit into a v2.4.2 bug fix release? |
rc83
pushed a commit
that referenced
this pull request
Jul 9, 2020
This fixes a bug where product and reactants could be wrongly activated even if the groups are full/empty. This is a problem important only when simulating at extreme conditions where the groups are almost empty or almost full.
|
I have created and pushed branch called release-2.4. It may be tagged as v2.4.2 if all test pass. – I have few tests failing locally but that can be different issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where products or reactants could be wrongly (de)activated even if the groups are full/empty. This is a problem important only when simulating at extreme conditions where the groups are nearly empty or nearly full. The issue could appear as a non-zero net-charge upon restarting an equilibration run which would typically be initiated with all molecules in their active state. The issue would not appear with swap moves and only if multiple products or reactants were involved in the reaction.