Test for multipoledistribution analysis #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - pos1: [1.0, 1.0, 0.0] | ||
| - pos1: [-1.0, -1.0, 0.0] | ||
| - neg1: [1.0, -1.0, 0.0] | ||
| - neg2: [-1.0, 1.0, 0.0] |
There was a problem hiding this comment.
should it not be neg1?
There was a problem hiding this comment.
It's on purpose since I want all moments to be non-zero in the test
bjornstenqvist
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test case for the multipole distribution analysis,
multipoledist, and also fixes a problem with the way the quadrupole moment was calculated, giving wrong results for the distribution analysis. Squash merge intended.