Possible performance improvements

mls-m5 · Nov 22, 2023 · c78338f · c78338f
1 parent 4883f3b
commit c78338f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/text/cursorrangeops.cpp b/src/text/cursorrangeops.cpp
@@ -15,7 +15,7 @@ std::vector<FString> contentLines(CursorRange range) {
     auto &buffer = begin.buffer();
 
     if (begin.y() == end.y()) {
-        auto line = buffer.lineAt(begin.y());
+        auto &line = buffer.lineAt(begin.y());
         return {{line.begin() + begin.x(), line.begin() + end.x()}};
     }
 

diff --git a/src/text/fstring.cpp b/src/text/fstring.cpp
@@ -156,7 +156,7 @@ std::vector<FString> FString::split(Utf8Char c) const {
     return ret;
 }
 
-FString FString::join(std::vector<FString> strings, Utf8Char c) {
+FString FString::join(const std::vector<FString> &strings, Utf8Char c) {
 
     size_t size = strings.size() - 1;
 

diff --git a/src/text/fstring.h b/src/text/fstring.h
@@ -164,7 +164,7 @@ class FString {
 
     std::vector<FString> split(Utf8Char c = '\n') const;
 
-    static FString join(std::vector<FString> strings, Utf8Char c = '\n');
+    static FString join(const std::vector<FString> &strings, Utf8Char c = '\n');
 
     FString operator+(const FString &other);