Put diagnostics on the right row

mls-m5 · Nov 3, 2023 · 101ff13 · 101ff13
1 parent 63ed10c
commit 101ff13
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/src/plugin/gdbdebugger.cpp b/src/plugin/gdbdebugger.cpp
@@ -211,7 +211,7 @@ void GdbDebugger::inputThread(std::istream &in) {
                     .breakpointNumber = match[1].str(),
                     .functionSignature = match[2].str(),
                     .filePath = match[3].str(),
-                    .lineNumber = std::stoul(match[4].str()),
+                    .lineNumber = std::stoul(match[4].str()) - 1,
                 });
             }
         }

diff --git a/src/plugin/idebugger.h b/src/plugin/idebugger.h
@@ -38,7 +38,7 @@ struct BreakpointInfo {
     std::string breakpointNumber;
     std::string functionSignature;
     std::string filePath;
-    size_t lineNumber;
+    size_t lineNumber; // medit line number, starting with 0
 };
 
 using BreakpointList =

diff --git a/src/plugin/lsp/lspplugin.cpp b/src/plugin/lsp/lspplugin.cpp
@@ -110,8 +110,8 @@ LspPlugin::Instance::Instance(LspConfiguration config, LspPlugin *parent)
                     //                        item.source, // item.source, could
                     //                        not get this to work
                     .message = item.message,
-                    .range = {toMeditPosition(item.range.start, true),
-                              toMeditPosition(item.range.end, true)},
+                    .range = {toMeditPosition(item.range.start, false),
+                              toMeditPosition(item.range.end, false)},
                 });
             }
 

diff --git a/src/plugin/rundebug.cpp b/src/plugin/rundebug.cpp
@@ -8,6 +8,7 @@
 #include "text/fstring.h"
 #include "views/editor.h"
 #include "views/mainwindow.h"
+#include <string>
 #include <string_view>
 
 void debug(std::shared_ptr<IEnvironment> env) {
@@ -68,9 +69,10 @@ void debug(std::shared_ptr<IEnvironment> env) {
                         d.push_back({
                             .type = DiagnosticType::Breakpoint,
                             .source = "debugger",
-                            .message = "breakpoint",
+                            .message = "breakpoint line " +
+                                       std::to_string(info.lineNumber + 1),
                             .range = {.begin = {0, info.lineNumber},
-                                      .end = {Position::max, info.lineNumber}},
+                                      .end = {1, info.lineNumber}},
                         });
                     }
 

diff --git a/src/views/bufferview.cpp b/src/views/bufferview.cpp
@@ -41,7 +41,7 @@ void BufferView::draw(IScreen &screen) {
         auto l = ty + yScroll();
         if (l < buffer().lines().size()) {
             auto hasLineDiagnostics =
-                buffer().diagnostics().findLineDiagnostic(l - 1);
+                buffer().diagnostics().findLineDiagnostic(l);
 
             auto &line = _buffer->lines().at(l);