Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML-2956: Make all aggregations return NaN when there is no data except for count #461

Merged
merged 4 commits into from
Oct 8, 2023

Conversation

alxtkr77
Copy link
Member

@alxtkr77 alxtkr77 closed this Sep 18, 2023
@alxtkr77 alxtkr77 reopened this Sep 18, 2023
@gtopper gtopper changed the title Make all aggregations return NaN when there is no data except for COUNT ML-2956: Make all aggregations return NaN when there is no data except for count Sep 18, 2023
@gtopper gtopper self-requested a review September 18, 2023 08:09
storey/table.py Outdated Show resolved Hide resolved
storey/table.py Outdated Show resolved Hide resolved
storey/table.py Show resolved Hide resolved
storey/table.py Show resolved Hide resolved
alxtkr77 and others added 2 commits October 2, 2023 10:20
Co-authored-by: Gal Topper <gal.topper@gmail.com>
@gtopper gtopper self-requested a review October 2, 2023 09:03
Copy link
Collaborator

@gtopper gtopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please run some mlrun feature store system tests on it before we merge and release this.

@gtopper gtopper merged commit 9d62d65 into mlrun:development Oct 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants