-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release version 2.17.0: "25 Din Mein Paisa Double" #308
Conversation
"25 Din Mein Paisa Double" translates to "Money doubled in 25 days". A famous dialogue from the movie "Fir Hera Pheri". If you aren't already familiar with this meme, see this video posted by Netfilx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, looks like the script worked. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, just noticed an issue. Because mlpack-bot does the release based on HEAD~1
, probably the best option is to rerun the script for a new PR.
* Improved installation and compilation instructions | ||
([#300](https://github.com/mlpack/ensmallen/pull/300)). | ||
### ensmallen 2.17.0: "25 Din Mein Paisa Double" | ||
###### 2021-05-07 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, @jonpsy, I just realized, this date is backwards with the format we have been using in other places---this says May 7, but it should be 2021-07-05
(e.g. July 5). Did you change anything in the script having to do with the date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah my bad, didn't change the script. I just wrote in YYYY/DD/MM format by mistake in HISTORY.md
Minor issue, though having a number (25) in the release name is potentially confusing with the version number (2.17). (Based on first hand experience with Armadillo, users can be trusted to make incorrect conclusions and do the wrong thing, treating the documentation as merely suggestions rather than as the canonical reference.) Perhaps there is a shorter version of "25 Din Mein Paisa Double" with similar intent, or maybe another quote from the "Fir Hera Pheri" movie? |
@conradsnicta Sure, I can just write "25" as "Pacchis" which translates to "Twenty Five" in Hindi. That should do the trick. |
Replacing 25 with Pacchis, would make the title a little bit longer, from what @conradsnicta wrote above that might be too long? |
Personally I don't think the length is a problem. Hopefully nobody is actually using the version string for anything! 😄 |
I can shorten other words, "Pachis Din Me Pesa Double" I think it's letter count should be more or less the same as the previous release (including space). |
That should be fine. The previous name was 35 characters, c.f. R> nchar("Pacchis Din Mein Paisa Double")
[1] 29
R> nchar("Severely Dented Can Of Polyurethane")
[1] 35 |
Not using the version string per say, but I do use the defines :) |
Sounds good :) |
I think, You should try ITN staging for numbers to words. So, Google and Microsoft speech APIs could benchmark it. |
This automatically-generated pull request adds the commits necessary to make the 2.17.0 release.
Once the PR is merged, mlpack-bot will tag the release as HEAD~1 (so that it doesn't include the new HISTORY block) and publish it.
Or, well, hopefully that will happen someday.
When you merge this PR, be sure to merge it using a rebase.
Changelog
CheckArbitraryFunctionTypeAPI extended for MOO support (#283).
Refactor NSGA2 (#263, #304).
Add Indicators for Multiobjective optimizers (#285).
Make Callback flexible for MultiObjective Optimizers (#289).
Add ZDT Test Suite (#273).
Add MOEA-D/DE Optimizer (#269).
Introduce Policy Methods for MOEA/D-DE (#293).
Add Das-Dennis weight initialization method (#295).
Add Dirichlet Weight Initialization (#296).
Improved installation and compilation instructions (#300).
Disable building the tests by default for faster installation (#303).
Modify matrix initialisation to take into account default element zeroing in Armadillo 10.5 (#305).