Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lookahead - Synchronization period type fix #153

Merged
merged 3 commits into from
Dec 28, 2019
Merged

Lookahead - Synchronization period type fix #153

merged 3 commits into from
Dec 28, 2019

Conversation

zoq
Copy link
Member

@zoq zoq commented Dec 26, 2019

The builds fails (gcc 9.2.1), if the return type is wrong.

@zoq
Copy link
Member Author

zoq commented Dec 26, 2019

Once this is merged, we should make another release.

rcurtin
rcurtin approved these changes Dec 27, 2019
View reviewed changes
Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, oops, I guess we missed it during review. :) Do you want to add a changelog entry to HISTORY.md? I can also do it during release, of course.

mlpack-bot[bot]
mlpack-bot bot approved these changes Dec 28, 2019
View reviewed changes
Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@rcurtin
Copy link
Member

rcurtin commented Dec 28, 2019

I'll make another release once #154 is merged. (should be tomorrow morning I guess) 👍

@rcurtin rcurtin merged commit 839b94d into mlpack:master Dec 28, 2019
@zoq
Copy link
Member Author

zoq commented Dec 28, 2019

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlpack-bot mlpack-bot[bot] mlpack-bot[bot] approved these changes

@rcurtin rcurtin rcurtin approved these changes

Assignees
No one assigned
Labels
c: optimizers t: bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoq @rcurtin