Some refactoring and SPaG fixes

[hopperelec]

Edit: Didn't mean to include #94 in this, but I'll probably just cause issues with merging if I try to remove it

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8bcf36e) 71.93% compared to head (5350c3b) 71.90%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   71.93%   71.90%   -0.03%     
==========================================
  Files          60       60              
  Lines        2444     2442       -2     
  Branches      514      514              
==========================================
- Hits         1758     1756       -2     
  Misses        626      626              
  Partials       60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

⚡ Preview for this PR: https://pr-95.chat-analytics.pages.dev
📊 Demo

[mlomb]

This is in fact shorter, but less readable. I don't usually remember which of the four arguments is what (less when there are three). Right now I see it as "everything with auto but left with 3px", so much easier. This kind of changes are handled by the CSS postprocessor so they have no impact.

There are a few cases of this

[hopperelec]

Fair enough, I didn't know LESS did optimization

[hopperelec]

There's quite a few places where you were already using this syntax; for consistency, should I expand those too?

[mlomb]

There's quite a few places where you were already using this syntax; for consistency, should I expand those too?

As you wish

[hopperelec]

Well, it's your project, so it should be as you wish, but so be it 😅

[mlomb]

By the way, what do you mean with "SPaG"? 🤔

[hopperelec]

By the way, what do you mean with "SPaG"? 🤔

Spelling, Punctuation and Grammar. Sorry, probably just a UK thing lol

[mlomb]

I carefully checked all the changes and I'm ready to merge!

---

I added the following again:

fieldset {
  display: grid;
  display: contents;
}

Which was necessary for the Stepper (homepage, while processing) to display correctly.

---

I rolled back changes in BitStream:

value >>>= 7; // from this
value = value >>> 7; // back to this

I don't recall correctly and can't find a source but I had problems with >>>= in some browsers (iirc older but not dead versions of Safari), so I prefer to keep it that way

---

Thanks for your PR once again! Lot of work, thanks!! 🎊🎊🎊

[hopperelec]

Hm I did definitely test the stepper a lot and didn't see any issues, I don't know what having two display properties is supposed to do. Of will. But that older browser issue makes sense, no worries!

[mlomb]

having two display properties is supposed to do

iirc it was a fallback