Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord - Locally stored users profile pictures not working #106

Closed
livingflore opened this issue Feb 16, 2024 · 4 comments · Fixed by #107
Closed

Discord - Locally stored users profile pictures not working #106

livingflore opened this issue Feb 16, 2024 · 4 comments · Fixed by #107
Labels
bug Something isn't working pipeline Related to the pipeline report Related to the report page

Comments

@livingflore
Copy link

livingflore commented Feb 16, 2024

If export by DCE was done with media from channels being stored locally (--media true), you wouldn't be able to see users profile picture as report being generated with validation of URL. I assume it would be possible to use profile pictures which being stored locally if report.html and media folder are in same directory, but if they are not - simply fall back to default avatar (discord icon).

@hopperelec
Copy link
Contributor

Not a fix, but you forgot to leave https:// at the start of the link you provided so it's acting as a relative link which doesn't work 😉Correct link

@livingflore
Copy link
Author

Not a fix, but you forgot to leave https:// at the start of the link you provided so it's acting as a relative link which doesn't work 😉Correct link

sry firefox moment

@livingflore livingflore changed the title Locally stored users profile pictures not working Discord - Locally stored users profile pictures not working Feb 17, 2024
mlomb added a commit that referenced this issue Feb 19, 2024
This will load avatars from local directories if exports have media files enabled.
Fixes #106
mlomb added a commit that referenced this issue Feb 19, 2024
This will load avatars from local directories if exports have media files enabled.
Fixes #106
@mlomb
Copy link
Owner

mlomb commented Feb 19, 2024

Hey @livingflore can you test in the PR link if the avatars have the correct path?

https://pr-107.chat-analytics.pages.dev

Edit: for context, we talked a bit on Discord, we concluded to use the path of the avatars if available.

@mlomb mlomb added bug Something isn't working report Related to the report page pipeline Related to the pipeline labels Feb 19, 2024
@livingflore
Copy link
Author

Hey @livingflore can you test in the PR link if the avatars have the correct path?

https://pr-107.chat-analytics.pages.dev

Edit: for context, we talked a bit on Discord, we concluded to use the path of the avatars if available.

yep, works perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pipeline Related to the pipeline report Related to the report page
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants