Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Moved API keys into secret.json so that it may be kept out of source control #2

Merged
merged 1 commit into from
Sep 17, 2015

Conversation

stevemcquaid
Copy link

No description provided.

@mloberg
Copy link
Owner

mloberg commented Sep 16, 2015

Definitely agree with moving sensitive information like this out of source control. However, I think this application might be better off being rewritten. There's a lot of weird things being done here and it's not making use of composer or any type of framework.

@stevemcquaid
Copy link
Author

I propose:

  1. Merge this request
  2. Create stable tag
  3. Cut a dev branch
  4. Create issues outlining the issues/user stories so that we can begin discussing framework and roadmap.

I love the simplicity of this project and look forward to working on it, whatever direction you think

@mloberg
Copy link
Owner

mloberg commented Sep 17, 2015

@stevemcquaid Ok. I'll work on that this weekend I think.

One suggestion for your PR is to have secret.json ignored by git and then have a secret.json.dist and instruct the user to copy the .dist file over and enter their credentials. Removing a file from git can sometimes be a hassle, especially when you get people that do git add .

@stevemcquaid
Copy link
Author

Awesome!

Good call. Updating now

@stevemcquaid
Copy link
Author

a87a447 <-- updated commit

mloberg added a commit that referenced this pull request Sep 17, 2015
Moved API keys into secret.json so that it may be kept out of source control
@mloberg mloberg merged commit fb2041c into mloberg:master Sep 17, 2015
@mloberg
Copy link
Owner

mloberg commented Sep 21, 2015

@stevemcquaid Check out #3 for v3 planning/discussion. I'm going to add some of my ideas later tonight, but if there was anything you wanted to add now, go for it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants