Make php artisan send-test-mail option --from optional

mll-lab · Apr 2, 2024 · 69b8a33 · 69b8a33
1 parent 7bd7d4f
commit 69b8a33
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,12 @@ See [GitHub releases](https://github.com/mll-lab/laravel-utils/releases).
 
 ## Unreleased
 
+## v4.12.0
+
+### Changed
+
+- Make `php artisan send-test-mail` option `--from` optional
+
 ## v4.11.0
 
 ### Added

diff --git a/src/Mail/SendTestMailCommand.php b/src/Mail/SendTestMailCommand.php
@@ -20,11 +20,13 @@ public function handle(): void
         $mail = new TestMail();
 
         $from = $this->option('from');
-        if (! is_string($from)) {
-            $fromType = gettype($from);
-            throw new \UnexpectedValueException("Expected option --from to be string, got {$fromType}.");
+        if (! is_null($from)) {
+            if (! is_string($from)) { // @phpstan-ignore-line option values can also be arrays
+                $fromType = gettype($from);
+                throw new \UnexpectedValueException("Expected option --from to be string, got {$fromType}.");
+            }
+            $mail->from($from);
         }
-        $mail->from($from);
 
         $to = $this->option('to');
         if (! is_string($to)) {