Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve reimautophasecorrection by removing outliers #206

Merged

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Dec 2, 2023

No description provided.

@jobo322 jobo322 linked an issue Dec 2, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (041c639) 91.67% compared to head (a02f770) 94.97%.

❗ Current head a02f770 differs from pull request most recent head d70da2c. Consider uploading reports for the commit d70da2c to get more accurate results

Files Patch % Lines
src/reim/reimAutoPhaseCorrection.ts 84.37% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   91.67%   94.97%   +3.29%     
==========================================
  Files         168      168              
  Lines        3290     3301      +11     
  Branches      825      826       +1     
==========================================
+ Hits         3016     3135     +119     
+ Misses        267      163     -104     
+ Partials        7        3       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jobo322 jobo322 requested review from targos and lpatiny December 3, 2023 01:02
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the order of imports (and configure your IDE to run ESLint on save).

I can't review the algo as I have no idea what this is about.

@jobo322
Copy link
Member Author

jobo322 commented Dec 4, 2023

Please fix the order of imports (and configure your IDE to run ESLint on save).

I can't review the algo as I have no idea what this is about.

Many thanks, I did setup the IDE for auto-eslint fixing.

@jobo322 jobo322 merged commit 7b00d93 into main Dec 4, 2023
8 checks passed
@jobo322 jobo322 deleted the 205-improve-reimautophasecorrection-by-removing-outliers branch December 4, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve reimAutoPhaseCorrection by removing outliers
2 participants