Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hilbert-transform could use FFT for non power of 2 data #202

Closed
lpatiny opened this issue Nov 26, 2023 · 0 comments · Fixed by #207
Closed

Hilbert-transform could use FFT for non power of 2 data #202

lpatiny opened this issue Nov 26, 2023 · 0 comments · Fixed by #207
Assignees
@josoriom

Comments

@lpatiny
Copy link
Member

lpatiny commented Nov 26, 2023

In case the data is not a power of 2 Hilbert transform could use xSampling but this should be an option. I don't think that it will be 100% the same result if you go through power of 2 (to be checked).

If it is not 100% please add an option 'forceFFT' that is only useful if it is not a power of 2 and we use xSampling.
@lpatiny lpatiny changed the title Hilbert-transform could Hilbert-transform could use FFT Nov 26, 2023
@lpatiny lpatiny changed the title Hilbert-transform could use FFT Hilbert-transform could use FFT for non power of 2 data Nov 26, 2023
@josoriom josoriom moved this from 🔴 Todo to 🟠 In Progress in NMR and Cheminfo projects organisation Nov 27, 2023
josoriom added a commit that referenced this issue Nov 28, 2023
@josoriom
feat: Allow xHilbertTransform to use FFT for array lengths non power …
74b0dc1 
…of 2 close #202
@lpatiny lpatiny closed this as completed in 14c0dde Dec 6, 2023
@github-project-automation github-project-automation bot moved this from 🟠 In Progress to 🟢 Done in NMR and Cheminfo projects organisation Dec 6, 2023
@mljs-bot mljs-bot mentioned this issue Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josoriom josoriom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(main): release 12.9.0 mljs/spectra-processing
2 participants
@lpatiny @josoriom