Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: change peak shape structure #68

Merged
merged 5 commits into from
Nov 18, 2021
Merged

feat!: change peak shape structure #68

merged 5 commits into from
Nov 18, 2021

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Nov 18, 2021

use Peak1D interface and Shape1D in the peak structure
remove properties from output soft, noiseLevel, fromTo
check the peak list to homogenize fwhm n width in optimizePeaks
generate the soft mask in joinBroadPeaks
use types from cheminfo-types
update ml-peak-shape-generator to 3.0.1

use Peak1D interface and Shape1D in the peak structure
remove properties from output soft, noiseLevel, fromTo
check the peak list to homogenize fwhm n width in optimizePeaks
generate the soft mask in joinBroadPeaks
use types from cheminfo-types
update ml-peak-shape-generator to 3.0.1
@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #68 (690e6e3) into master (e9e8522) will decrease coverage by 1.09%.
The diff coverage is 93.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   97.52%   96.42%   -1.10%     
==========================================
  Files           6        6              
  Lines         283      308      +25     
  Branches       93      101       +8     
==========================================
+ Hits          276      297      +21     
- Misses          7       11       +4     
Impacted Files Coverage Δ
src/post/joinBroadPeaks.ts 90.00% <84.37%> (-3.62%) ⬇️
src/gsd.ts 99.38% <100.00%> (-0.04%) ⬇️
src/post/broadenPeaks.ts 100.00% <100.00%> (ø)
src/post/groupPeaks.ts 100.00% <100.00%> (ø)
src/post/optimizePeaks.ts 91.89% <100.00%> (+3.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e8522...690e6e3. Read the comment docs.

@jobo322 jobo322 force-pushed the changePeakStructure branch from 6831bb4 to 230eb3e Compare November 18, 2021 02:42
@jobo322 jobo322 force-pushed the changePeakStructure branch from 230eb3e to e5e08d0 Compare November 18, 2021 02:46
@jobo322 jobo322 merged commit f97285c into master Nov 18, 2021
@jobo322 jobo322 deleted the changePeakStructure branch November 18, 2021 03:08
@mljs-bot mljs-bot mentioned this pull request Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant