Setup typescript

[wadjih-bencheikh18]

finished the migration

[codecov]

Codecov Report

Merging #66 (955d9fb) into master (edd8a79) will increase coverage by 0.23%.
The diff coverage is 97.36%.

❗ Current head 955d9fb differs from pull request most recent head fc50c1b. Consider uploading reports for the commit fc50c1b to get more accurate results

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   97.28%   97.52%   +0.23%     
==========================================
  Files           5        6       +1     
  Lines         258      283      +25     
  Branches       82       93      +11     
==========================================
+ Hits          251      276      +25     
  Misses          7        7              

Impacted Files	Coverage Δ
src/index.ts	100.00% <ø> (ø)
src/post/optimizePeaks.ts	88.88% <90.00%> (ø)
src/post/joinBroadPeaks.ts	93.61% <90.90%> (ø)
src/gsd.ts	99.41% <100.00%> (ø)
src/post/broadenPeaks.ts	100.00% <100.00%> (ø)
src/post/groupPeaks.ts	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd8a79...fc50c1b. Read the comment docs.

[wadjih-bencheikh18]

spectrum-generator updated
fix types to avoid cast

[targos]

https://github.com/wadjih-bencheikh18/global-spectral-deconvolution/blob/setup-typescript/.github/workflows/nodejs.yml#L9

Updating to 16.x here should help the lint CI job to pass.

[stropitek]

Thanks for the PR

As a general comment (I haven't left a comment everywhere I saw that) I think you should review which types can be deduplicated and which types should be exported by the library

[stropitek]

Please use the following template:
https://github.com/zakodium/.github/blob/main/workflow-templates/nodejs-ts.yml
You should add the code coverage option to it though

For reference the template is based on the reusable workflow here: https://github.com/zakodium/workflows/blob/main/.github/workflows/nodejs.yml

[stropitek]

@wadjih-bencheikh18 I think you misunderdstood

Can you please copy-paste the entire workflow from https://github.com/zakodium/.github/blob/main/workflow-templates/nodejs-ts.yml as a base and then modify to activate code coverage? (and also replace $default-branch placeholder with actual name of default branch)

[targos]

Code coverage is active by default.

[wadjih-bencheikh18]

i think it's fixed now can you check? @stropitek

[stropitek]

No, not yet. If you look at the github actions you'll see that some checks are executed multiple times. The reusable workflow already contains all common checks. You can remove all other jobs.

[wadjih-bencheikh18]

what about now?

[wadjih-bencheikh18]

Ready to merge

[stropitek]

Thanks!