Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: homogenize and generalize output #63

Merged
merged 9 commits into from
Oct 11, 2021
Merged

feat!: homogenize and generalize output #63

merged 9 commits into from
Oct 11, 2021

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Oct 9, 2021

No description provided.

homogenize output
rename base to noiseLevel
by default width is FWHM of a gaussian
remove properties 'left' and 'right'
homogenize output
remove properties 'from' and 'to'
make a copy
homogenize output
@lpatiny
Copy link
Member

lpatiny commented Oct 11, 2021

@jobo322 Could you take care that the tests are passing ?

@targos
Copy link
Member

targos commented Oct 11, 2021

Please remove node 10 and 15, and add node 16 to the test matrix.

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #63 (33a9115) into master (e2c843a) will decrease coverage by 0.03%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   97.31%   97.28%   -0.04%     
==========================================
  Files           5        5              
  Lines         261      258       -3     
  Branches       86       82       -4     
==========================================
- Hits          254      251       -3     
  Misses          7        7              
Impacted Files Coverage Δ
src/post/joinBroadPeaks.js 92.85% <88.88%> (+0.17%) ⬆️
src/gsd.js 99.38% <100.00%> (-0.02%) ⬇️
src/post/broadenPeaks.js 100.00% <100.00%> (ø)
src/post/groupPeaks.js 100.00% <100.00%> (ø)
src/post/optimizePeaks.js 86.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2c843a...33a9115. Read the comment docs.

@jobo322 jobo322 merged commit 2b3a403 into master Oct 11, 2021
@jobo322 jobo322 deleted the homogenizeOutput branch October 11, 2021 14:08
@mljs-bot mljs-bot mentioned this pull request Oct 11, 2021
@jobo322 jobo322 restored the homogenizeOutput branch February 22, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants