-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: peak picking returns id and keep id if it exists #108
Merged
jobo322
merged 21 commits into
master
from
107-peak-picking-returns-id-and-keep-id-if-it-exists
Aug 27, 2022
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
10d0495
chore: initial steps to keep id property
jobo322 4843af3
feat(broadenPeaks): conditional type
jobo322 02ee40a
chore(joinBroadPeaks): conditional type
jobo322 7484afd
feat(setShape): generic function n output option
jobo322 18a9dd2
chore(gsd): returns id as required
jobo322 fa73b36
chore: remove aditionals types
jobo322 08a888b
chore: refactor broadenPeaks
jobo322 ff5d2f0
chore(joinBroadPeaks): refactor
jobo322 e2c3a75
chore: fix eslint
jobo322 7ca00e5
chore(joinBroadPeaks): remove conditional type
jobo322 a88251b
chore: don't add id in gsd
jobo322 38765d0
chore(optimizePeaks): conditional types
jobo322 99c2a94
chore: gsd returns id n test cases fixed
jobo322 2514b5f
fix(addMissingShape): convert to pure
jobo322 96c0cff
fix(gsd): assert result to GSDPeakID[]
jobo322 443cd16
fix(joinBroadPeaks): returns width ids
jobo322 c68e8de
fix(optimizePeaks): convert to generic n conditional types
jobo322 6799f90
feat: addMissingIDs
jobo322 7321cd5
fix: prettier
jobo322 be3ee3e
chore: add prerelease of ml-spectra-fitting
jobo322 1ecf11a
chore: update ml-spectra-fitting
jobo322 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really know the shape ? I think I didn't put it because it was not really defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BroadenPeak increases the width of the peak by a factor, the input is a
GSDPeak
structure but the propertyshape
was added, that is why I added shape as optional inGSDBroadenPeak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok