LIBSEARCH-112 Remove Rails as a dependency for Spectrum #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sinatra has been added in. Cleanup is still required.
Getting Rake to run. Getting Rspec to run. Setting APP_ENV to RAILS_ENV if APP_ENV isn't set.
* Fixed a warning about redfined hash key in icon_metadata_component.rb
* Bugfix for the logout route in auth.rb
* Updates for rspec
* Added a Bundler.require
* Added a Spectrum::Json.configure
* Replaced rails_helper.rb with spec_helper.rb
* Removed individual require statements
* Added rack-test
* Updated route tests that were dependent on rspec-rails features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes Rails and replaces it with Sinatra.