Bug: Advanced Search boolean types get deselected or cannot get reselected.

[erinesullivan]

Overview

When adding multiple query options to search, when you start typing, the boolean type (AND, OR, NOT) disappears. You then cannot select AND. Two problems were discovered in the reducer:

1. state[dsUid].fieldedSearches[index].booleanTypes does not exist, making booleanType return undefined.
2. The booleanType ? ... ternary operator returns false when set to AND because the value of AND is 0, which is also equivalent to false. It now specifically checks if it is a number and is less than the number of available boolean types to prevent the use of a magic number that does not exist as a type.

Anything else?

Focusing on a radio button turned the button into a square. That is because of the :focus pseudo-class defining border-radius: 2px. Adding border-radius: 50%!important to the radio button resolves this style bug.

Testing

• Make sure the PR is consistent in these browsers:
  • Chrome
  • Firefox
  • Safari
  • Edge
• Run accessibility tests:
  • WAVE
  • ARC Toolkit
  • axe DevTools
• Go to Advanced Search, and type in multiple queries.
  • Can you select all redio buttons? Even with keyboard?
  • Do any of the radio selections disappear when you start typing?
  • Does search successfully run the full query?