Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating .focus style and applying to cards. #472

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Creating .focus style and applying to cards. #472

merged 1 commit into from
Aug 5, 2024

Conversation

erinesullivan
Copy link
Contributor

Overview

When navigating ShelfBrowseCarousel by keyboard, there is no focus state for the cards. This pull request creates a .focus class

Testing

  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • View a full catalog record and tab through it with the keyboard. Does an outline show around the cards?

@erinesullivan erinesullivan self-assigned this Aug 5, 2024
@erinesullivan erinesullivan merged commit 50fd0e5 into master Aug 5, 2024
6 checks passed
@erinesullivan erinesullivan deleted the bug-shelf-browse-card-keyboard-focus branch August 5, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erinesullivan erinesullivan

Labels
Type: Accessibility Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erinesullivan