Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBSEARCH-987] Add a Class to <a> element in the "Resource Access" component #468

Conversation

erinesullivan
Copy link
Contributor

Overview

To simplify Google Tag Manager triggers, the class access-link-cell has been added to the first column of every Holding row in tbody.

This pull request resolves LIBSEARCH-987.

Testing

  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Check a record that has holdings. Inspect the element that has the link Get This, Available online, Go to item, Go to database, Go to online journal, Request access, etc. and see if its parent cell has the class access-link-cell.

@erinesullivan erinesullivan self-assigned this Jul 12, 2024
@erinesullivan erinesullivan merged commit 1d16619 into master Jul 12, 2024
6 checks passed
@erinesullivan erinesullivan deleted the LIBSEARCH-978-add-a-class-to-a-element-in-the-resource-access-component branch July 12, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant