Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIBSEARCH-957] Shelf Carousel implementation #454

Merged
merged 43 commits into from
Jul 25, 2024
Merged

[LIBSEARCH-957] Shelf Carousel implementation #454

merged 43 commits into from
Jul 25, 2024

Conversation

erinesullivan
Copy link
Contributor

@erinesullivan erinesullivan commented Apr 25, 2024 •
edited
Loading

Overview

When viewing a full catalog record, if a call number exists, a carousel appears above the MARC table that shows the next or previous 22 records in the same order as you would see in Catalog Browse.

This pull request closes LIBSEARCH-957.

Testing

  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Check out a full catalog record that has a call number.
    • Does a carousel appear?
    • Can you scroll through it?
    • Does the amount of items increase/decrease per slide depending on window size?
    • Can you always return to the current item?

@erinesullivan erinesullivan self-assigned this Apr 25, 2024
@erinesullivan
Updating Browse in call number list link, updating card links to po…
414dafe 
…int to Browse, making `Return to current item` disabled if viewing middle slide, adding hover effect for next/previous buttons
@erinesullivan
Turning off animation for users who prefer reduced motion, adding ani…
395a2ca 
…mation after clicking `Return to current item`.
@erinesullivan
Adding Continue browse... cards at the beginning and end of the car…
07ed6f9 
…ousel.
@erinesullivan
Separate Current Record into own div. Change display to grid so…
5e5d314 
… banner will be higher than the other cards. Add check to see if current record is not first/last record in list.
@erinesullivan
Update mobile design to show blank cards. Hide left/right blank card …
6b00b1e 
…if on first/last slide.
@erinesullivan
Recenter slideshow on resize.
9d0e36c
@erinesullivan
Merge branch 'master' into nearby-on-shelf-carousel
03cb5b9
@erinesullivan
Created a function that checks which page the current record is in, a…
f876d76 
…nd set that as `middlePage`.
@erinesullivan
Merge branch 'master' into nearby-on-shelf-carousel
5c1eec3
@erinesullivan
Mobile: Moving arrows to sides and removing blank cards.
0069ed4
@erinesullivan
Making button labels singular or plural depending on number of items …
e7a6d7b 
…in carousel slides.
@erinesullivan
Closing annoying gap between CURRENT RECORD banner and border.
16208be
@erinesullivan
Merge branch 'master' into nearby-on-shelf-carousel
f3091b7
@erinesullivan
Merge branch 'master' into nearby-on-shelf-carousel
c4c7f9b
@erinesullivan
Breaking up carousel and fetching logic.
8d1e733
@erinesullivan
Adding logic to find browse descriptor information.
d29c7b9
@erinesullivan
Updating test-data with a final structure. Updating the carousel to…
355ad64 
… handle the new data.
@erinesullivan
Adding fetch functionality to ShelfBrowse.
441fb6e
@erinesullivan
Removing the need for test data.
af8b5a6
@erinesullivan
Adding record uid check for the current record in case other items …
6c43d99 
…share the same call number.
@erinesullivan
Adding logic to test against uid for currentItem.
051459d
@erinesullivan
Making all cards point to full records, except for first and last non…
6302d54 
…-current cards.
@erinesullivan
bug: Trimming callNumber to eliminate surrounding whitespace for co…
881bdda 
…mparison.
@erinesullivan
Changing Return to current item to Return to current record.
5e025a6
@erinesullivan
Adding production URL for fetching.
bb1f31d
@erinesullivan
Replacing item with record.
a38c076
@erinesullivan erinesullivan changed the title Nearby on shelf carousel [LIBSEARCH-957] Shelf Carousel implementation Jul 25, 2024
@erinesullivan erinesullivan merged commit eace972 into master Jul 25, 2024
6 checks passed
@erinesullivan erinesullivan deleted the nearby-on-shelf-carousel branch July 25, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erinesullivan erinesullivan

Labels
Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erinesullivan