Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Tabs, Tab, and TabPanel components. #446

Merged
merged 10 commits into from
Mar 25, 2024
Merged

Conversation

erinesullivan
Copy link
Contributor

Overview

The original Tabs component used two dependencies: react-tabs and @emotion/styled. To replace those dependencies, Tabs, Tab, and TabPanel components were built from scratch. This now allows us to have full control.

Testing

  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Check out Advanced Search and Citations under full record views. Click around and see if anything is broken.

@erinesullivan erinesullivan self-assigned this Mar 25, 2024
@erinesullivan erinesullivan merged commit 9239dde into master Mar 25, 2024
6 checks passed
@erinesullivan erinesullivan deleted the custom-tabs-component branch March 25, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant