history
and react-router-update
- Part 4
#439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request is a continuation of removing
withRouter
in order to updatehistory
andreact-router-dom
. These components have been rewritten to remove the need forwithRouter
:AdvancedSearchForm
FullRecord
RecordListContainer
SearchBox
GetThisPage
GetThisFindIt
URLSearchQueryWrapper
Anything else?
To align with current React practices, these class components have been converted to functional components:
AdvancedSearchForm
FullRecord
GetThisFindIt
GetThisPage
URLSearchQueryWrapper
Testing