Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

history and react-router-update - Part 3 #438

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

erinesullivan
Copy link
Contributor

Overview

This pull request is a continuation of removing withRouter in order to update history and react-router-dom. DatastoreNavigation and List have been rewritten to remove the need for withRouter.

Anything else?

Alerts component has been simplified and applied where applicable.

Testing

  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Poke around the site and see if anything is broken.

@erinesullivan erinesullivan self-assigned this Mar 8, 2024
@erinesullivan erinesullivan merged commit 3a7be8e into master Mar 8, 2024
6 checks passed
@erinesullivan erinesullivan deleted the history-react-router-dom-update-part-3 branch March 8, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant