Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing src/modules/analytics. #428

Merged
merged 8 commits into from
Feb 29, 2024
Merged

Removing src/modules/analytics. #428

merged 8 commits into from
Feb 29, 2024

Conversation

erinesullivan
Copy link
Contributor

Overview

GAListener was not used in the site, so it has been deleted. When working on simplifying handleGAClick, it was realized that it would never call because no element exists with the attributes starting with data-ga-. The function was removed, thus making src/modules/analytics empty.

Anything else?

ReactGA

react-ga was initializing a retired Universal Analytics account, making it useless. The code has been removed. It was the only instance of using react-ga, so the dependency has been uninstalled.

Pull request templates

With uninstalling react-ga, the pull request templates have been updated to list the current set of dependencies, along with more accurate information as to why the pull request exists.

App

To align with current React practices, this class component has been converted to a functional component:

  • App

Testing

  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Load the site and poke around to see if anything is broken.

@erinesullivan erinesullivan merged commit f927f8b into master Feb 29, 2024
6 checks passed
@erinesullivan erinesullivan deleted the analytics-cleanup branch February 29, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant