Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBSEARCH-146] Update experts panel with link to Experts page #423

Conversation

erinesullivan
Copy link
Contributor

Overview

Figma designs have been updated to show Find more specialists linking to Find a Specialist.

This pull request closes LIBSEARCH-146.

Anything else?

Code and styling have been simplified for all related components.

ShowAllSpecialists

ShowAllChildren was only ever used in SpecialistsList, so the component was renamed to ShowAllSpecialists and moved to src/modules/specialists/components/.

SpecialistsWrapper

SpecialistsWrapper was an over engineered component, simply replaced by the SpecialistList component. The original component has been deleted.

Functional Components

To align with current React practices, these class components have been converted to functional components:

  • ShowAllSpecialists
  • RecordList

Testing

  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Make a search that includes specialists.
    • Does the Find more specialists link appear?
    • Do you see it on the first page of each datastore result?
    • Does the Show all # Library Specialists button appear?
      • Does it show the remaining specialists when clicked on?
  • Check the rest of the site and see if everything looks okay.

@erinesullivan erinesullivan self-assigned this Feb 20, 2024
@erinesullivan erinesullivan merged commit 933d8ed into master Feb 20, 2024
6 checks passed
@erinesullivan erinesullivan deleted the LIBSEARCH-146-update-experts-panel-with-link-to-experts-page branch February 20, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant