[LIBSEARCH-938] Investigate whether CSS can be used to hide "search only" holdings across all bib records #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be-used-to-hide-search-only-holdings-across-all-bib-records
… materials' is checked under 'Catalog'.
- Removing need for `ResourceAccessLoading` as it requires no arguments and is used once. - Added `record-holders-container` to help with GA events.
erinesullivan
deleted the
LIBSEARCH-938-investigate-whether-css-can-be-used-to-hide-search-only-holdings-across-all-bib-records
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Without touching Spectrum, we need to figure out a way how to hide all Catalog holdings that have
Search only (no full text)whileRemove search-only HathiTrust materialsis checked. This pull request filters out the incoming holdings when true.This pull request resolves LIBSEARCH-938.
Anything else?
The
Holderscomponent has been simplified, removing the need forpreExpandedIdsandcreateId.ResourceAccessLoadingResourceAccessLoadingwas a very simple component, only ever called once inResourceAccessContainer. The code was copied directly into the container, and the original file was deleted.ContextProviderContextProviderwas a class component, and has been converted to a functional component to align with current React practices.Testing
Remove search-only HathiTrust materialsunselected.HathiTrust Digital Libraryholdings that showSearch only (no full text)?Remove search-only HathiTrust materials, do you not see anyHathiTrust Digital Libraryholdings that showSearch only (no full text)?