Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIBSEARCH-926] Deploy Browse as a full service (UI) #105

Merged
merged 2 commits into from
Feb 12, 2024
Merged

[LIBSEARCH-926] Deploy Browse as a full service (UI) #105

merged 2 commits into from
Feb 12, 2024

Conversation

erinesullivan
Copy link
Collaborator

@erinesullivan erinesullivan commented Dec 20, 2023 •
edited
Loading

Overview

Catalog Browse is officially out of beta! This pull request removes everything beta related.

This pull request resolves LIBSEARCH-926.

Testing

  • Run the tests to make sure they pass (docker-compose run --rm web bundle exec rspec).
  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Load up the site and check the dropdown. Has [BETA] been removed?
    • Has the m-callout component been removed containing the feedback survey.

@erinesullivan erinesullivan self-assigned this Dec 20, 2023
@erinesullivan erinesullivan added the enhancement New feature or request label Dec 20, 2023
@erinesullivan erinesullivan changed the title Deploy Browse as a full service (UI) [LIBSEARCH-926] Deploy Browse as a full service (UI) Dec 20, 2023
niquerio
niquerio approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@niquerio niquerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. This should be all that's needed to make this not-beta anymore from a user's perspective.

views/layout.erb Show resolved Hide resolved
niquerio
niquerio approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@niquerio niquerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@niquerio niquerio merged commit 7dcdc59 into main Feb 12, 2024
1 check passed
@erinesullivan erinesullivan deleted the LIBSEARCH-926-deploy-browse-as-a-full-service-ui branch February 13, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niquerio niquerio niquerio approved these changes

Assignees

@erinesullivan erinesullivan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erinesullivan @niquerio