Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIBSEARCH-814] ACCOUNT: Remove "Favorites" from Account navigation #240

Merged
merged 1 commit into from
Dec 19, 2022
Merged

[LIBSEARCH-814] ACCOUNT: Remove "Favorites" from Account navigation #240

merged 1 commit into from
Dec 19, 2022

Conversation

erinesullivan
Copy link
Collaborator

@erinesullivan erinesullivan commented Nov 14, 2022 •
edited by niquerio
Loading

Overview

As part of the Favorites Decommissioning, remove
”My Favorites” from the top of all pages in https://account.lib.umich.edu/.

  • Remove from left-side navigation
  • Remove tile from landing page (possibly keep it, inactive, with an explanation, pending review of Account analytics)

This pull request closes LIBSEARCH-814.

Testing

  • Run the tests to make sure they pass (docker-compose run --rm web bundle exec rspec).
    • Break the new/updated unit tests to make sure they're working properly.
  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Check and see if Favorites shows up in the sidebar or in Account Overview.

@erinesullivan erinesullivan self-assigned this Nov 14, 2022
@erinesullivan erinesullivan marked this pull request as ready for review December 6, 2022 18:00
niquerio
niquerio approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@niquerio niquerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it locally. It looks good (not in the front page cards, and not on the sidebar anymore) and the tests pass.

@erinesullivan
Copy link
Collaborator Author

Will not be merging this until on or after December 20.

@erinesullivan erinesullivan merged commit 4ebd437 into main Dec 19, 2022
@erinesullivan erinesullivan deleted the LIBSEARCH-814-account-remove-favorites-from-account-navigation branch December 19, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niquerio niquerio niquerio approved these changes

Assignees

@erinesullivan erinesullivan

Labels
account-overview favorites
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erinesullivan @niquerio