Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved training_torch to experimental and added a README #142

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

jeremy-syn
Copy link
Contributor

I merged the torch code submitted by @andreysher into master, but I'd like to move it into an experimental subdirectory, just to indicate that equivalence with the reference code has not been verified. So to make a closed-division submission, someone would need to load the reference weights and validate that the results are the same.

@jeremy-syn jeremy-syn requested a review from a team as a code owner October 9, 2023 15:52
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@cskiraly cskiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it is better to have this in an experimental folder.

@cskiraly cskiraly merged commit e1b857b into master Nov 13, 2023
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants